Skip to content

Commit b174567

Browse files
VinozzZdmathieu
authored andcommitted
instrumentation/net/http/otelhttp: upgrade semconv to v1.26.0 (open-telemetry#5923)
Bases on the discussion in open-telemetry#5902 , we have came to the conclusion that there's no new stable attributes introduced in semconv v1.26.0 for otelhttp. We can directly bump from v1.24.0 to v1.26.0 Changes in this PR: - bump semconv from v1.24.0 to v1.26.0 for otelhttp - rename the `instrumentation/net/http/otelhttp/internal/semconv/v1.24.0.go` to `instrumentation/net/http/otelhttp/internal/semconv/httpconv.go` to match with client side naming convention --------- Co-authored-by: Damien Mathieu <[email protected]>
1 parent 41f0b5a commit b174567

File tree

4 files changed

+3
-3
lines changed

4 files changed

+3
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
1717
This module provides an OpenTelemetry logging bridge for `go.uber.org/zap`. (#5191)
1818
- The `go.opentelemetry.io/contrib/config` package supports configuring `with_resource_constant_labels` for the prometheus exporter. (#5890)
1919
- Add new runtime metrics to `go.opentelemetry.io/contrib/instrumentation/runtime`, which are still disabled by default. (#5870)
20-
- Support for the `OTEL_HTTP_CLIENT_COMPATIBILITY_MODE=http/dup` environment variable in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` to emit attributes for both the v1.20.0 and v1.24.0 semantic conventions. (#5401)
20+
- Support for the `OTEL_HTTP_CLIENT_COMPATIBILITY_MODE=http/dup` environment variable in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` to emit attributes for both the v1.20.0 and v1.26.0 semantic conventions. (#5401)
2121

2222
### Removed
2323

instrumentation/net/http/otelhttp/internal/semconv/v1.24.0.go renamed to instrumentation/net/http/otelhttp/internal/semconv/httpconv.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
"strings"
99

1010
"go.opentelemetry.io/otel/attribute"
11-
semconvNew "go.opentelemetry.io/otel/semconv/v1.24.0"
11+
semconvNew "go.opentelemetry.io/otel/semconv/v1.26.0"
1212
)
1313

1414
type newHTTPServer struct{}

instrumentation/net/http/otelhttp/internal/semconv/util.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010
"strings"
1111

1212
"go.opentelemetry.io/otel/attribute"
13-
semconvNew "go.opentelemetry.io/otel/semconv/v1.24.0"
13+
semconvNew "go.opentelemetry.io/otel/semconv/v1.26.0"
1414
)
1515

1616
// splitHostPort splits a network address hostport of the form "host",

0 commit comments

Comments
 (0)