fix: simplify sorting function for score levels by removing unnecessary check for scoreA and scoreB

rappm · rappm · commit 487cfd97e7a7 · 2025-06-24T10:49:12.000+02:00
diff --git a/clients/assessment_component/src/assessment/pages/AssessmentOverviewPage/AssessmentOverviewPage.tsx b/clients/assessment_component/src/assessment/pages/AssessmentOverviewPage/AssessmentOverviewPage.tsx
@@ -45,7 +45,7 @@ export const AssessmentOverviewPage = (): JSX.Element => {
             scoreLevels.find((s) => s.courseParticipationID === rowB.original.courseParticipationID)
               ?.scoreLevel ?? ScoreLevel.VeryBad,
           )
-          return scoreA && scoreB ? scoreA - scoreB : 0
+          return scoreA - scoreB
         },
         extraData: scoreLevels.map((s) => ({
           courseParticipationID: s.courseParticipationID,

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ export const AssessmentOverviewPage = (): JSX.Element => {`
`45`	`45`	`scoreLevels.find((s) => s.courseParticipationID === rowB.original.courseParticipationID)`
`46`	`46`	`?.scoreLevel ?? ScoreLevel.VeryBad,`
`47`	`47`	`)`
`48`		`- return scoreA && scoreB ? scoreA - scoreB : 0`
	`48`	`+ return scoreA - scoreB`
`49`	`49`	`},`
`50`	`50`	`extraData: scoreLevels.map((s) => ({`
`51`	`51`	`courseParticipationID: s.courseParticipationID,`