Skip to content

Commit 42f9c36

Browse files
s100dhmlau
authored andcommitted
fix: stop using _extends
Signed-off-by: Samuel Hughes <[email protected]>
1 parent 27a0d0c commit 42f9c36

File tree

4 files changed

+5
-9
lines changed

4 files changed

+5
-9
lines changed

lib/dao.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ const sanitizeQueryOrData = utils.sanitizeQuery;
3131
const setScopeValuesFromWhere = utils.setScopeValuesFromWhere;
3232
const idEquals = utils.idEquals;
3333
const mergeQuery = utils.mergeQuery;
34-
const util = require('util');
3534
const assert = require('assert');
3635
const BaseModel = require('./model');
3736
const debug = require('debug')('loopback:dao');
@@ -209,9 +208,9 @@ DataAccessObject.applyProperties = function(data, inst) {
209208
let properties = this.definition.settings.properties;
210209
properties = properties || this.definition.settings.attributes;
211210
if (typeof properties === 'object') {
212-
util._extend(data, properties);
211+
Object.assign(data, properties);
213212
} else if (typeof properties === 'function') {
214-
util._extend(data, properties.call(this, data, inst) || {});
213+
Object.assign(data, properties.call(this, data, inst) || {});
215214
} else if (properties !== false) {
216215
const scope = this.defaultScope(data, inst) || {};
217216
if (typeof scope.where === 'object') {

lib/model.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ const DataAccessUtils = require('./model-utils');
2424
const Observer = require('./observer');
2525
const Hookable = require('./hooks');
2626
const validations = require('./validations');
27-
const _extend = util._extend;
2827
const utils = require('./utils');
2928
const fieldsToArray = utils.fieldsToArray;
3029
const uuid = require('uuid');
@@ -85,7 +84,7 @@ ModelBaseClass.prototype._initProperties = function(data, options) {
8584
// Convert the data to be plain object to avoid pollutions
8685
data = data.toObject(false);
8786
}
88-
const properties = _extend({}, ctor.definition.properties);
87+
const properties = Object.assign({}, ctor.definition.properties);
8988
data = data || {};
9089

9190
if (typeof ctor.applyProperties === 'function') {

lib/validations.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
const g = require('strong-globalize')();
99
const util = require('util');
10-
const extend = util._extend;
1110

1211
/*!
1312
* Module exports
@@ -777,7 +776,7 @@ function configure(cls, validation, args, opts) {
777776
conf.validation = validation;
778777
args.forEach(function(attr) {
779778
if (typeof attr === 'string') {
780-
const validation = extend({}, conf);
779+
const validation = Object.assign({}, conf);
781780
validation.options = opts || {};
782781
cls.validations[attr] = cls.validations[attr] || [];
783782
cls.validations[attr].push(validation);

test/kvao.suite.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,11 @@
66
'use strict';
77

88
const debug = require('debug')('test');
9-
const extend = require('util')._extend;
109
const fs = require('fs');
1110
const path = require('path');
1211

1312
module.exports = function(dataSourceFactory, connectorCapabilities) {
14-
connectorCapabilities = extend({
13+
connectorCapabilities = Object.assign({
1514
// Even when the backend supports millisecond precision,
1615
// it's better to use intervals at least 10ms long in the tests
1716
ttlPrecision: 10,

0 commit comments

Comments
 (0)