Skip to content

Commit d4deac4

Browse files
authored
feat: allow node 20 for the TS SDK (#1506)
Allow Node 20 as a runtime environment for the Looker TypeScript SDK
1 parent f95fdce commit d4deac4

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

.github/workflows/tssdk-ci.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
matrix:
4444
os:
4545
- ubuntu
46-
node-version: [22.x]
46+
node-version: [20.x, 22.x]
4747

4848
steps:
4949
- name: Cancel Previous Runs
@@ -122,7 +122,7 @@ jobs:
122122
runs-on: ${{ matrix.os }}-latest
123123
strategy:
124124
matrix:
125-
node-version: [22.x]
125+
node-version: [20.x, 22.x]
126126
os:
127127
- ubuntu
128128
looker: ${{ fromJson(needs.setup.outputs.matrix_json) }}

packages/sdk-node/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -201,9 +201,9 @@ The [deprecated NodeJS `request` package](https://www.npmjs.com/package/request)
201201
The streaming method callback signature changed from `(readable: Readable) => Promise<x>` to `(response: Response) => Promise<x>`. Using `Response` as the parameter to the callback greatly
202202
increases the flexibility of streaming implementations and provides other valuable information like `Content-Type` and other headers to the streaming callback.
203203

204-
For the Browser SDK (`@looker/sdk`), the standard `fetch` function is still used. For the Node SDK (`@looker/sdk-node`), the global [`fetch`](https://nodejs.org/api/globals.html#fetch) function from NodeJS v22 is used.
204+
For the Browser SDK (`@looker/sdk`), the standard `fetch` function is still used. For the Node SDK (`@looker/sdk-node`), the global [`fetch`](https://nodejs.org/api/globals.html#fetch) function from NodeJS is used, which was marked **stable** in version 22.
205205

206-
This means the Looker Node SDK now uses NodeJS v22.
206+
This means the Looker Node SDK now requires Node 20 or above.
207207

208208
The streaming version of the SDK methods should be initialized using the same `AuthSession` as the main SDK to reduce authentication thrashing.
209209

packages/sdk/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ The [deprecated NodeJS `request` package](https://www.npmjs.com/package/request)
8282
The streaming method callback signature changed from `(readable: Readable) => Promise<x>` to `(response: Response) => Promise<x>`. Using `Response` as the parameter to the callback greatly
8383
increases the flexibility of streaming implementations and provides other valuable information like `Content-Type` and other headers to the streaming callback.
8484

85-
For the Browser SDK (`@looker/sdk`), the standard `fetch` function is still used. For the Node SDK (`@looker/sdk-node`), the global [`fetch`](https://nodejs.org/api/globals.html#fetch) function from NodeJS v22 is used.
85+
For the Browser SDK (`@looker/sdk`), the standard `fetch` function is still used. For the Node SDK (`@looker/sdk-node`), the global [`fetch`](https://nodejs.org/api/globals.html#fetch) function from NodeJS is used, which was marked **stable** in version 22.
8686

87-
This means the Looker Node SDK now uses NodeJS v22.
87+
This means the Looker Node SDK now requires Node 20 or above.
8888

8989
The streaming version of the SDK methods should be initialized using the same `AuthSession` as the main SDK to reduce authentication thrashing.
9090

shell.nix

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ with nixpkgs;
44
with lib;
55
mkShell {
66
name = "sdk-codegen";
7-
buildInputs =[nodejs_22 yarn];
7+
buildInputs =[nodejs yarn];
88
}

0 commit comments

Comments
 (0)