fix: change visconfig types to reflect new getter (#1350)

ryandunlavy · rdunlavy-google · web-flow · commit c7648d9792bf · 2023-08-14T16:12:55.000-07:00
* Fix types for VisualizationConfigImpl

---------

Co-authored-by: Ryan Dunlavy &lt;rdunlavy@google.com&gt;
diff --git a/packages/extension-sdk/src/connect/visualization/types.ts b/packages/extension-sdk/src/connect/visualization/types.ts
@@ -98,6 +98,7 @@ export interface VisualizationConfig {
   queryFieldDimensions: Dimension[]
   queryFieldTableCalculations: TableCalculation[]
   queryFieldPivots: PivotConfig[]
+  visConfig: RawVisConfig
 }
 
 export interface QueryResponse {
diff --git a/packages/extension-sdk/src/connect/visualization/visualization_sdk.ts b/packages/extension-sdk/src/connect/visualization/visualization_sdk.ts
@@ -92,8 +92,8 @@ class VisualizationConfigImpl implements VisualizationConfig {
     this._visConfig = visConfig
   }
 
-  get visConfig(): RawVisConfig | undefined {
-    return this._visConfig
+  get visConfig(): RawVisConfig {
+    return this._visConfig || {}
   }
 
   get queryFieldMeasures(): Measure[] {

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,7 @@ export interface VisualizationConfig {`
`98`	`98`	`queryFieldDimensions: Dimension[]`
`99`	`99`	`queryFieldTableCalculations: TableCalculation[]`
`100`	`100`	`queryFieldPivots: PivotConfig[]`
	`101`	`+ visConfig: RawVisConfig`
`101`	`102`	`}`
`102`	`103`
`103`	`104`	`export interface QueryResponse {`
Original file line number	Diff line number	Diff line change
`@@ -92,8 +92,8 @@ class VisualizationConfigImpl implements VisualizationConfig {`
`92`	`92`	`this._visConfig = visConfig`
`93`	`93`	`}`
`94`	`94`
`95`		`- get visConfig(): RawVisConfig \| undefined {`
`96`		`- return this._visConfig`
	`95`	`+ get visConfig(): RawVisConfig {`
	`96`	`+ return this._visConfig \|\| {}`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`get queryFieldMeasures(): Measure[] {`