Skip to content

Commit bae0fe3

Browse files
bryans99jkasterdrstrangelooker
authored
fix: remove reference to react in extension-sdk (#1532)
Co-authored-by: John Kaster <[email protected]> Co-authored-by: Dr. Strangelove <[email protected]>
1 parent 1a0a89b commit bae0fe3

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

packages/extension-sdk/src/connect/tile/tile_sdk.ts

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
2525
*/
2626

27-
import type { MouseEvent } from 'react';
2827
import { NOT_DASHBOARD_MOUNT_NOT_SUPPORTED_ERROR } from '../../util/errors';
2928
import { ExtensionRequestType } from '../types';
3029
import type { ExtensionHostApiImpl } from '../extension_host_api';

packages/extension-sdk/src/connect/tile/types.ts

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
2525
*/
2626

27-
import type { MouseEvent } from 'react';
2827
import type { IQuery } from '@looker/sdk';
2928

3029
/**

packages/extension-tile-playground/src/components/Inspector/components/EventTester/EventTester.tsx

+7-5
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
2525
*/
2626
import React, { useCallback, useContext, useState } from 'react';
27-
import type { MouseEvent } from 'react';
2827
import {
2928
Accordion2,
3029
ButtonOutline,
@@ -58,17 +57,20 @@ export const EventTester: React.FC = () => {
5857
}, [tileSDK]);
5958

6059
const toggleCrossFilterClick = useCallback(
61-
(event: MouseEvent) => {
60+
(event: React.MouseEvent<HTMLButtonElement>) => {
6261
// TODO pivot and row data needs to be populated
63-
tileSDK.toggleCrossFilter({ pivot: {} as any, row: {} as any }, event);
62+
tileSDK.toggleCrossFilter(
63+
{ pivot: {} as any, row: {} as any },
64+
event as unknown as MouseEvent
65+
);
6466
},
6567
[tileSDK]
6668
);
6769

6870
const openDrillMenuClick = useCallback(
69-
(event: MouseEvent) => {
71+
(event: React.MouseEvent<HTMLButtonElement>) => {
7072
// TODO links data needs to be populated
71-
tileSDK.openDrillMenu({ links: [] }, event);
73+
tileSDK.openDrillMenu({ links: [] }, event as unknown as MouseEvent);
7274
},
7375
[tileSDK]
7476
);

0 commit comments

Comments
 (0)