feat(setting): remove ValueIntRangeMaximum of v2-data-engine-guaranteed-instance-manager-cpu

Longhorn 10662

Signed-off-by: Derek Su <[email protected]>

Author: derekbit

types/setting.go

@@ -1379,7 +1379,7 @@ var (
 		Description: "Number of millicpus on each node to be reserved for each instance manager pod when the V2 Data Engine is enabled. The Storage Performance Development Kit (SPDK) target daemon within each instance manager pod uses 1 or multiple CPU cores. Configuring a minimum CPU usage value is essential for maintaining engine and replica stability, especially during periods of high node workload. \n\n" +
 			"WARNING: \n\n" +
 			"  - Value 0 means unsetting CPU requests for instance manager pods for v2 data engine. \n\n" +
-			"  - This integer value is range from 1000 to 8000. \n\n" +
+			"  - The smallest acceptable integer value is 1000. \n\n" +
 			"  - After this setting is changed, the v2 instance manager pod using this global setting will be automatically restarted without instances running on the v2 instance manager. \n\n",
 		Category: SettingCategoryDangerZone,
 		Type:     SettingTypeInt,
@@ -1388,7 +1388,6 @@ var (
 		Default:  "1250",
 		ValueIntRange: map[string]int{
 			ValueIntRangeMinimum: 1000,
-			ValueIntRangeMaximum: 8000,
 		},
 	}
 

types/types.go

@@ -1208,9 +1208,8 @@ func ValidateCPUReservationValues(settingName SettingName, instanceManagerCPUStr
 	switch settingName {
 	case SettingNameGuaranteedInstanceManagerCPU, SettingNameV2DataEngineGuaranteedInstanceManagerCPU:
 		isUnderLimit := instanceManagerCPU < valueIntRange[ValueIntRangeMinimum]
-		isOverLimit := instanceManagerCPU > valueIntRange[ValueIntRangeMaximum]
-		if isUnderLimit || isOverLimit {
-			return fmt.Errorf("invalid requested instance manager CPUs. Valid instance manager CPU range between %v - %v millicpu", valueIntRange[ValueIntRangeMinimum], valueIntRange[ValueIntRangeMaximum])
+		if isUnderLimit {
+			return fmt.Errorf("invalid requested instance manager CPUs. Valid instance manager CPU range is larger than %v millicpu", valueIntRange[ValueIntRangeMinimum])
 		}
 	}
 	return nil