Merge pull request #1 from locmai/fix/logic-in-dropping-metric

fix: dropping non-cumulative logic

Author: vsabella

exporter/prometheusexporter/accumulator.go

@@ -165,8 +165,8 @@ func (a *lastValueAccumulator) accumulateGauge(metric pdata.Metric, il pdata.Ins
 func (a *lastValueAccumulator) accumulateSum(metric pdata.Metric, il pdata.InstrumentationLibrary, now time.Time) (n int) {
 	doubleSum := metric.Sum()
 
-	// Drop metrics with non-cumulative aggregations
-	if doubleSum.AggregationTemporality() != pdata.MetricAggregationTemporalityCumulative {
+	// Drop metrics with non-cumulative aggregations and is not monotonic increasing
+	if doubleSum.AggregationTemporality() != pdata.MetricAggregationTemporalityCumulative && !metric.Sum().IsMonotonic() {
 		return
 	}
 

exporter/prometheusexporter/accumulator_test.go

@@ -199,6 +199,22 @@ func TestAccumulateMetrics(t *testing.T) {
 				dp.SetTimestamp(pdata.NewTimestampFromTime(ts))
 			},
 		},
+		{
+			name: "DeltaCumulativeMonotonicSum", // For testing the delta cumulative but monotonic metric #4153
+			metric: func(ts time.Time, v float64, metrics pdata.MetricSlice) {
+				metric := metrics.AppendEmpty()
+				metric.SetName("test_metric")
+				metric.SetDataType(pdata.MetricDataTypeSum)
+				metric.Sum().SetIsMonotonic(true)
+				metric.Sum().SetAggregationTemporality(pdata.MetricAggregationTemporalityDelta)
+				metric.SetDescription("test description")
+				dp := metric.Sum().DataPoints().AppendEmpty()
+				dp.SetDoubleVal(v)
+				dp.Attributes().InsertString("label_1", "1")
+				dp.Attributes().InsertString("label_2", "2")
+				dp.SetTimestamp(pdata.NewTimestampFromTime(ts))
+			},
+		},
 		{
 			name: "Histogram",
 			metric: func(ts time.Time, v float64, metrics pdata.MetricSlice) {