consistent-spacing-between-blocks throws in 11.0.0

[perrin4869]

After upgrading, I am getting the following error:

TypeError: Cannot read properties of undefined (reading '0')
Occurred while linting /home/perrin4869/services-typescript/services/distid/src/batch.integration.ts:16
Rule: "mocha/consistent-spacing-between-blocks"
    at isFirstStatementInScope (file:///home/perrin4869/services-typescript/node_modules/eslint-plugin-mocha/rules/consistent-spacing-between-blocks.js:6:35)
    at checkCurrentLayer (file:///home/perrin4869/services-typescript/node_modules/eslint-plugin-mocha/rules/consistent-spacing-between-blocks.js:32:22)
    at suite:exit (file:///home/perrin4869/services-typescript/node_modules/eslint-plugin-mocha/rules/consistent-spacing-between-blocks.js:52:17)
    at callVisitorIfExists (file:///home/perrin4869/services-typescript/node_modules/eslint-plugin-mocha/ast/mocha-visitors.js:20:9)
    at callVisitors (file:///home/perrin4869/services-typescript/node_modules/eslint-plugin-mocha/ast/mocha-visitors.js:57:9)
    at CallExpression:exit (file:///home/perrin4869/services-typescript/node_modules/eslint-plugin-mocha/ast/mocha-visitors.js:148:17)
    at ruleErrorHandler (/home/perrin4869/services-typescript/node_modules/eslint/lib/linter/linter.js:1311:33)
    at /home/perrin4869/services-typescript/node_modules/eslint/lib/linter/safe-emitter.js:45:46
    at Array.forEach (<anonymous>)
    at Object.emit (/home/perrin4869/services-typescript/node_modules/eslint/lib/linter/safe-emitter.js:45:26)

[lo1tuma]

Any chance you can share the actual code that is causing this error?

[perrin4869]

It's part of a private repo, so I would have to reproduce it separately. Unfortunately my public repos are still using eslint 8...
I will try to find some time to reproduce it this week

[perrin4869]

Here is a file that introduces the error:

describe("foo", () => {
    it("bar", () => {}).timeout(30_000);
});

I think it has to do with the timeout call, because removing it fixes the issue

[perrin4869]

btw, I opened this as a separate issue last year here:
#364

but the following code triggers mocha/no-setup-in-describe (or at least it did in 10.x), and should work on mocha>=11:

describe("my suite", () => {
  before(() => {}).timeout(1000);
});

thought I'd bring it up since it is very similar

[lo1tuma]

Thanks, that was indeed to root cause. The issue is fixed now and I will make another release in the next days.
Regarding no-setup-in-describe I haven’t looked into it yet, but I guess it is still an issue.

[maplesteve]

@lo1tuma Would be great, if you can make the release. We're having several repos, that are stuck since v11 because of this issue. Thanks!