Skip to content

Add test for asdouble #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks
Tracked by #221
llvm-beanz opened this issue May 1, 2025 · 1 comment
Open
5 tasks
Tracked by #221

Add test for asdouble #115

llvm-beanz opened this issue May 1, 2025 · 1 comment

Comments

@llvm-beanz
Copy link
Collaborator

llvm-beanz commented May 1, 2025

https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/asdouble
https://github.com/llvm/llvm-project/blob/dc68166912baf5120389304ba317f818f406b4bd/clang/lib/Headers/hlsl/hlsl_alias_intrinsics.h#L427

In Test\Feature\HLSLLib create

  • Test for 32 bit types (< intrinsic >.test)
  • Make sure to test for all vector sizes

I think the test should use BufferExact rule

A .test file should contain

  • a source portion; If multiple .test files can use the same source; it can go in its own file and be referenced in the run portion of each .test file instead.
@@ -0,0 +1,54 @@
#--- source.hlsl

StructuredBuffer<float4> In : register(t0);
RWStructuredBuffer<float> Out : register(u1);

[numthreads(1,1,1)]
void main() {
// A single test can test for all scalar/vector length as shown here.
  Out[0] = length(In[0]); // Test float4
  Out[1] = length(In[1].x); // Test float
  Out[2] = length(In[1].yzw); // Test float3
  Out[3] = length(In[1].yz); // Test float2
}
  • a yaml portion; If multiple .test files can use the same YAML, it can go in its own file and be referenced in the run portion of each .test file instead.
//--- pipeline.yaml

---
Shaders:
  - Stage: Compute
    Entry: main
    DispatchSize: [1, 1, 1]
Buffers:
  - Name: In
    Format: Float32
    Stride: 16
    Data: [ 4, 4, 4, 4, 3.14159, 0, 5, 12 ]
  - Name: Out
    Format: Float32
    Stride: 4
    ZeroInitSize: 12
  - Name: ExpectedOut # The result we expect
    Format: Float32
    Stride: 4
    Data: [ 8, 3.14159, 13, 5 ]
Results:  # A test might have more than 1 result.
  - Result: Test1
    Rule: BufferFuzzy # there is also a BufferExact rule
    ULPT: 1
    Actual: Out
    Expected: ExpectedOut
DescriptorSets:
  - Resources:
    - Name: In
      Kind: StructuredBuffer
      DirectXBinding:
        Register: 0
        Space: 0
      VulkanBinding:
        Binding: 0
    - Name: Out
      Kind: RWStructuredBuffer
      DirectXBinding:
        Register: 1
        Space: 0
      VulkanBinding:
        Binding: 1
...
#--- end
  • A run portion; which will be unique to each .test file.
# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o 

Tests for 64 bit floating point should have a # REQUIRES: Double.

@spall
Copy link
Collaborator

spall commented May 22, 2025

See this bug: llvm/llvm-project#140998

@damyanp damyanp moved this to Ready in HLSL Support May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

2 participants