Skip to content

Commit 6dd09dc

Browse files
fsfodvgvassilev
authored andcommitted
[clang-tools-extra] Fix add_clang_library usage
If a add_clang_library call doesn't specify building as STATIC or SHARED library they are implicitly added to the list static libraries that is linked in to clang-cpp shared library. Because the clang-tools-extra libraries targets were declared after clang-cpp they by luck never got linked to clang-cpp. This change is required for clang symbol visibility macros on windows to work correctly for clang tools since we need to distinguish if a target being built will be importing or exporting clang symbols from the clang-cpp DLL.
1 parent 0e8555d commit 6dd09dc

File tree

45 files changed

+46
-46
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+46
-46
lines changed

clang-tools-extra/clang-apply-replacements/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ set(LLVM_LINK_COMPONENTS
22
Support
33
)
44

5-
add_clang_library(clangApplyReplacements
5+
add_clang_library(clangApplyReplacements STATIC
66
lib/Tooling/ApplyReplacements.cpp
77

88
DEPENDS

clang-tools-extra/clang-change-namespace/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
Support
44
)
55

6-
add_clang_library(clangChangeNamespace
6+
add_clang_library(clangChangeNamespace STATIC
77
ChangeNamespace.cpp
88

99
DEPENDS

clang-tools-extra/clang-doc/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set(LLVM_LINK_COMPONENTS
44
FrontendOpenMP
55
)
66

7-
add_clang_library(clangDoc
7+
add_clang_library(clangDoc STATIC
88
BitcodeReader.cpp
99
BitcodeWriter.cpp
1010
ClangDoc.cpp

clang-tools-extra/clang-include-fixer/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ set(LLVM_LINK_COMPONENTS
22
support
33
)
44

5-
add_clang_library(clangIncludeFixer
5+
add_clang_library(clangIncludeFixer STATIC
66
IncludeFixer.cpp
77
IncludeFixerContext.cpp
88
InMemorySymbolIndex.cpp

clang-tools-extra/clang-include-fixer/find-all-symbols/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
FrontendOpenMP
44
)
55

6-
add_clang_library(findAllSymbols
6+
add_clang_library(findAllSymbols STATIC
77
FindAllSymbols.cpp
88
FindAllSymbolsAction.cpp
99
FindAllMacros.cpp

clang-tools-extra/clang-include-fixer/plugin/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
add_clang_library(clangIncludeFixerPlugin
1+
add_clang_library(clangIncludeFixerPlugin STATIC
22
IncludeFixerPlugin.cpp
33

44
LINK_LIBS

clang-tools-extra/clang-move/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
FrontendOpenMP
44
)
55

6-
add_clang_library(clangMove
6+
add_clang_library(clangMove STATIC
77
Move.cpp
88
HelperDeclRefGraph.cpp
99

clang-tools-extra/clang-query/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set(LLVM_LINK_COMPONENTS
44
FrontendOpenMP
55
)
66

7-
add_clang_library(clangQuery
7+
add_clang_library(clangQuery STATIC
88
Query.cpp
99
QueryParser.cpp
1010

clang-tools-extra/clang-reorder-fields/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set(LLVM_LINK_COMPONENTS
33
support
44
)
55

6-
add_clang_library(clangReorderFields
6+
add_clang_library(clangReorderFields STATIC
77
ReorderFieldsAction.cpp
88

99
DEPENDS

clang-tools-extra/clang-tidy/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ configure_file(
88
${CMAKE_CURRENT_BINARY_DIR}/clang-tidy-config.h)
99
include_directories(BEFORE ${CMAKE_CURRENT_BINARY_DIR})
1010

11-
add_clang_library(clangTidy
11+
add_clang_library(clangTidy STATIC
1212
ClangTidy.cpp
1313
ClangTidyCheck.cpp
1414
ClangTidyModule.cpp

0 commit comments

Comments
 (0)