Skip to content

[Feature request] Allow to override main outbound invite headers #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devniel opened this issue May 29, 2025 · 0 comments
Open

[Feature request] Allow to override main outbound invite headers #379

devniel opened this issue May 29, 2025 · 0 comments

Comments

@devniel
Copy link

devniel commented May 29, 2025

Hello,

Please, Is it possible to add a way to override main headers?, that way we can set custom From headers which are different for some telephony providers

 sip.CreateSIPParticipantRequest(
  sip_trunk_id=sip_trunk_id,
  sip_call_to="33749127211",
  sip_number="2505272605",
  headers={
   "From": "Anonymous <sip:[email protected]>;tag=cbfbeb02-e408-4dd4-8274-eb87d39211f1"
 },
)

With the current implementation, the headers are appended and then a 'Bad Request' is thrown because 2 From headers were sent.

https://github.com/livekit/sip/blob/main/pkg/sip/outbound.go#L872

I will open a PR if possible as the change is simple.

Thanks!

@devniel devniel changed the title [Feature request] Allow to override core outbound invite headers [Feature request] Allow to override main outbound invite headers May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant