feat: remove optional private grafana (#1783)

Author: merll

helmfile.d/helmfile-60.teams.yaml

@@ -79,7 +79,10 @@ releases:
           fullnameOverride: {{ $teamId }}-po-grafana
           grafana.ini:
             "auth.generic_oauth":
-              role_attribute_path: contains(groups[*], 'admin') && 'Admin' || contains(groups[*], 'platform-admin') && 'Admin' || contains(groups[*], 'team-{{ $teamId }}') && 'Editor'{{ if not ($team | get "managedMonitoring.private" false) }} || 'Viewer'{{- end }}
+              role_attribute_path: >-
+                contains(groups[*], 'admin') && 'Admin' ||
+                contains(groups[*], 'platform-admin') && 'Admin' ||
+                contains(groups[*], 'team-{{ $teamId }}') && 'Editor'
             server:
               root_url: https://grafana-{{ $teamId }}.{{ $domain }}
             analytics:

values-changes.yaml

@@ -312,3 +312,6 @@ changes:
     relocations:
       - 'oidc.adminGroupID': 'oidc.platformAdminGroupID'
       - 'oidc.teamAdminGroupID': 'oidc.allTeamsAdminGroupID'
+  - version: 31
+    deletions:
+      - 'teamConfig.{team}.managedMonitoring.private'

values-schema.yaml

@@ -1141,9 +1141,6 @@ definitions:
           alertmanager:
             type: boolean
             default: false
-          private:
-            type: boolean
-            default: false
       networkPolicy:
         ingressPrivate:
           title: Enable filtering of ingress traffic inside the cluster