Skip to content

Commit 4ab74e0

Browse files
authored
fix: ensure correct working directory and increase retry timeout (#1882)
1 parent 37bdd3c commit 4ab74e0

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

src/cmd/apply.ts

+3-4
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { getCurrentVersion, getImageTag, writeValuesToFile } from 'src/common/va
1212
import { HelmArguments, getParsedArgs, helmOptions, setParsedArgs } from 'src/common/yargs'
1313
import { ProcessOutputTrimmed } from 'src/common/zx-enhance'
1414
import { Argv, CommandModule } from 'yargs'
15-
import { $ } from 'zx'
15+
import { $, cd } from 'zx'
1616
import { applyAsApps } from './apply-as-apps'
1717
import {
1818
cloneOtomiChartsInGitea,
@@ -146,12 +146,11 @@ const apply = async (): Promise<void> => {
146146
if (!argv.label && !argv.file) {
147147
await retry(async (bail) => {
148148
try {
149+
cd(rootDir)
149150
await applyAll()
150151
} catch (e) {
151152
d.error(e)
152-
await $`helm uninstall wait-for-otomi-realm -n maintenance`.nothrow().quiet()
153-
await $`kubectl delete job wait-for-otomi-realm -n maintenance`.nothrow().quiet()
154-
d.info(`Retrying in ${retryOptions.maxRetryTime} ms`)
153+
d.info(`Retrying in ${retryOptions.maxTimeout} ms`)
155154
throw e
156155
}
157156
}, retryOptions)

src/common/k8s.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
/* eslint-disable no-loop-func */
22
/* eslint-disable no-await-in-loop */
3+
import { AppsV1Api, CoreV1Api, CustomObjectsApi, KubeConfig, V1Secret } from '@kubernetes/client-node'
4+
import { V1ResourceRequirements } from '@kubernetes/client-node/dist/gen/model/v1ResourceRequirements'
35
import retry, { Options } from 'async-retry'
46
import { AnyAaaaRecord, AnyARecord } from 'dns'
57
import { resolveAny } from 'dns/promises'
@@ -16,8 +18,6 @@ import { env } from './envalid'
1618
import { hfValues } from './hf'
1719
import { parser } from './yargs'
1820
import { askYesNo } from './zx-enhance'
19-
import { AppsV1Api, CoreV1Api, CustomObjectsApi, KubeConfig, V1Secret } from '@kubernetes/client-node'
20-
import { V1ResourceRequirements } from '@kubernetes/client-node/dist/gen/model/v1ResourceRequirements'
2121

2222
export const secretId = `secret/otomi/${DEPLOYMENT_PASSWORDS_SECRET}`
2323

@@ -243,7 +243,7 @@ type WaitTillAvailableOptions = Options & {
243243

244244
export const waitTillGitRepoAvailable = async (repoUrl): Promise<void> => {
245245
const retryOptions: Options = {
246-
retries: 10,
246+
retries: 20,
247247
maxTimeout: 30000,
248248
}
249249
const d = terminal('common:k8s:waitTillGitRepoAvailable')
@@ -253,7 +253,7 @@ export const waitTillGitRepoAvailable = async (repoUrl): Promise<void> => {
253253
// the ls-remote exist with zero even if repo is empty
254254
await $`git ls-remote ${repoUrl}`
255255
} catch (e) {
256-
d.warn(e.message)
256+
d.warn(`The ${repoUrl} is not yet reachable. Retrying in ${retryOptions.maxTimeout} ms`)
257257
throw e
258258
}
259259
}, retryOptions)

0 commit comments

Comments
 (0)