fix: skip assignment of team-admin to argocd admin roles (#1818)

Co-authored-by: jeho <[email protected]>

Author: merll

charts/team-ns/templates/argocd/argocd-project.yaml

@@ -58,8 +58,11 @@ spec:
     - p, proj:team-{{ $v.teamId }}:platform-admin, *, *, team-{{ $v.teamId }}/*, allow
     groups:
     - platform-admin
+    {{- if not (eq $v.teamId "admin") }}
     - team-{{ $v.teamId }}
+    {{- end }}
 {{- end }}
+{{- if not (eq $v.teamId "admin") }}
   - name: team-member
     description: Team member privileges to team-{{ $v.teamId }}
 {{- if or (has "argocd" $v.selfService.apps) $v.otomi.isMultitenant }}
@@ -76,13 +79,12 @@ spec:
 {{- end }}
     groups:
     - team-{{ $v.teamId }}
+{{- end }}
   # A role which provides read-only access to all applications in the project
   - name: read-only
     description: Read-only privileges to team-{{ $v.teamId }}
     policies:
     - p, proj:team-{{ $v.teamId }}:read-only, applications, get, team-{{ $v.teamId }}/*, allow
-{{- if not $v.otomi.isMultitenant }}
-{{- end }}
     groups:
     - team-viewer
   - name: ci-role