fix: remove type from services

Author: ElderMatt

tests/bootstrap/input-local-dev.yaml

@@ -58,14 +58,12 @@ teamConfig:
         name: httpbin
         ownHost: true
         port: 80
-        type: public
       - id: a106eb22-8c06-41b6-ab15-97aafb0888b5
         ingressClassName: platform
         name: nginx-deployment
         ownHost: true
         paths: []
         port: 80
-        type: public
       - id: 91f6af98-ad8e-4111-b916-cf1b5bdcafb0
         ingressClassName: platform
         ksvc:
@@ -74,7 +72,6 @@ teamConfig:
         ownHost: true
         paths: []
         port: 80
-        type: public
     workloads:
       - name: nodejs-helloworld
         url: https://github.com/linode/apl-nodejs-helloworld.git

tests/bootstrap/input.yaml

@@ -57,14 +57,12 @@ teamConfig:
         name: httpbin
         ownHost: true
         port: 80
-        type: public
       - id: a106eb22-8c06-41b6-ab15-97aafb0888b5
         ingressClassName: platform
         name: nginx-deployment
         ownHost: true
         paths: []
         port: 80
-        type: public
       - id: 91f6af98-ad8e-4111-b916-cf1b5bdcafb0
         ingressClassName: platform
         ksvc:
@@ -73,7 +71,6 @@ teamConfig:
         ownHost: true
         paths: []
         port: 80
-        type: public
     workloads:
       - name: nodejs-helloworld
         url: https://github.com/linode/apl-nodejs-helloworld.git

tests/fixtures/env/teams/admin/services/hello-admin.yaml

@@ -9,4 +9,3 @@ spec:
     name: hello-admin
     ownHost: true
     port: 80
-    type: public

tests/fixtures/env/teams/demo/services/has-cert-svc.yaml

@@ -8,4 +8,3 @@ spec:
     name: has-cert-svc
     paths:
         - /jeho
-    type: public

tests/fixtures/env/teams/demo/services/hello-auth.yaml

@@ -11,4 +11,3 @@ spec:
     ownHost: true
     paths: []
     port: 80
-    type: public

tests/fixtures/env/teams/demo/services/hello-blue-green.yaml

@@ -15,5 +15,4 @@ spec:
         enabled: true
         weightV1: 90
         weightV2: 10
-    type: public
     useCname: false

tests/fixtures/env/teams/demo/services/hello.yaml

@@ -26,5 +26,4 @@ spec:
         enabled: true
         weightV1: 70
         weightV2: 30
-    type: public
     useCname: true

tests/fixtures/env/teams/demo/services/service-a.yaml

@@ -5,4 +5,3 @@ metadata:
         apl.io/teamId: demo
 spec:
     name: service-a
-    type: cluster

tests/fixtures/env/teams/demo/services/service-b.yaml

@@ -5,4 +5,3 @@ metadata:
         apl.io/teamId: demo
 spec:
     name: service-b
-    type: cluster

tests/fixtures/env/teams/demo/services/service-d.yaml

@@ -5,4 +5,3 @@ metadata:
         apl.io/teamId: demo
 spec:
     name: service-d
-    type: cluster

tests/fixtures/env/teams/demo/services/service-e.yaml

@@ -24,5 +24,4 @@ spec:
         enabled: true
         weightV1: 50
         weightV2: 50
-    type: public
     useCname: true

tests/fixtures/env/teams/demo/services/some-svc.yaml

@@ -6,4 +6,3 @@ metadata:
 spec:
     name: some-svc
     port: 80
-    type: cluster

tests/fixtures/env/teams/demo/services/tlspass.yaml

@@ -9,4 +9,3 @@ spec:
     name: tlspass
     port: 443
     tlsPass: true
-    type: public

tests/network-policies/env/teams/services.a1.yaml

@@ -3,76 +3,28 @@ teamConfig:
     services:
       - name: ce1
         port: 8080
-        networkPolicy:
-          ingressPrivate:
-            mode: DenyAll
-          egressPublic:
-            - domain: 'httpbin.org'
-              ports:
-                - protocol: HTTPS
-                  number: 443
-            - domain: '116.203.255.68'
-              ports:
-                - protocol: TCP
-                  number: 443
         id: 2bb00d03-7d9d-4590-961c-425423291a35
-        type: cluster
       - name: ce2
         port: 8080
         id: 2bb00d03-7d9d-4590-961c-425423291a34
-        type: cluster
       - name: s1
         port: 8080
         id: 6c901b91-e8a4-4422-8c9e-b12e077692f1
-        type: cluster
-        networkPolicy:
-          ingressPrivate:
-            mode: AllowAll
       - name: s2
         port: 8080
         id: 6c901b91-e8a4-4422-8c9e-b12e077692f2
-        type: cluster
-        networkPolicy:
-          ingressPrivate:
-            mode: AllowOnly
-            allow:
-              - team: a1
       - name: s3
         port: 8080
         id: 6c901b91-e8a4-4422-8c9e-b12e077692f3
-        type: cluster
-        networkPolicy:
-          ingressPrivate:
-            mode: AllowOnly
-            allow:
-              - team: a2
       - name: s4
         port: 8080
         id: 6c901b91-e8a4-4422-8c9e-b12e077692f4
-        type: cluster
-        networkPolicy:
-          ingressPrivate:
-            mode: DenyAll
       - name: s5
         port: 8080
         id: 6c901b91-e8a4-4422-8c9e-b12e077692f5
-        type: cluster
-        networkPolicy:
-          ingressPrivate:
-            mode: AllowOnly
-            allow:
-              - team: a1
-              - team: a2
       - name: s6
         port: 8080
         id: 6c901b91-e8a4-4422-8c9e-b12e077692f6
-        type: cluster
-        networkPolicy:
-          ingressPrivate:
-            mode: AllowOnly
-            allow:
-              - team: a1
-                service: c6
       - name: s7
         id: 6d4a4710-f7ac-4586-9940-7969cfe30b67
         ksvc:
@@ -93,10 +45,3 @@ teamConfig:
               memory: 64Mi
           containerPort: 8080
         ownHost: true
-        type: public
-        networkPolicy:
-          ingressPrivate:
-            mode: AllowOnly
-            allow:
-              - team: a1
-                service: c7