Skip to content

Commit 93542d4

Browse files
authored
Address gaps in readme & make targets (#129)
1 parent 040d574 commit 93542d4

File tree

2 files changed

+19
-17
lines changed

2 files changed

+19
-17
lines changed

Makefile

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,11 @@ undeploy: undeploy-config
3434

3535
quickstart: build deploy
3636

37-
deploy-samples: deploy
38-
kubectl wait --for=condition=Established=True \
39-
crds/subscriptions.hoptimator.linkedin.com \
40-
crds/kafkatopics.hoptimator.linkedin.com \
41-
crds/sqljobs.hoptimator.linkedin.com
42-
kubectl apply -f ./deploy/samples
37+
deploy-demo: deploy
38+
kubectl apply -f ./deploy/samples/demodb.yaml
4339

44-
undeploy-samples: undeploy
45-
kubectl delete -f ./deploy/samples || echo "skipping"
40+
undeploy-demo: undeploy
41+
kubectl delete -f ./deploy/samples/demodb.yaml || echo "skipping"
4642

4743
deploy-flink: deploy
4844
kubectl create namespace flink || echo "skipping"
@@ -74,7 +70,6 @@ undeploy-kafka:
7470
kubectl delete pvc -l strimzi.io/name=one-kafka -n kafka || echo "skipping"
7571
kubectl delete -f "https://strimzi.io/install/latest?namespace=kafka" -n kafka || echo "skipping"
7672
kubectl delete -f ./deploy/samples/kafkadb.yaml || echo "skipping"
77-
kubectl delete -f ./deploy/samples/demodb.yaml || echo "skipping"
7873
kubectl delete namespace kafka || echo "skipping"
7974

8075
# Deploys Venice cluster in docker and creates two stores in Venice. Stores are not managed via K8s for now.
@@ -88,17 +83,15 @@ undeploy-venice:
8883
kubectl delete -f ./deploy/samples/venicedb.yaml || echo "skipping"
8984
docker compose -f ./deploy/docker/venice/docker-compose-single-dc-setup.yaml down
9085

91-
deploy-dev-environment: deploy deploy-flink deploy-kafka deploy-venice
86+
deploy-dev-environment: deploy deploy-demo deploy-flink deploy-kafka deploy-venice
9287
kubectl wait --for=condition=Established=True \
9388
crds/subscriptions.hoptimator.linkedin.com \
9489
crds/kafkatopics.hoptimator.linkedin.com \
9590
crds/sqljobs.hoptimator.linkedin.com
9691
kubectl apply -f ./deploy/dev/
97-
kubectl apply -f ./deploy/samples/demodb.yaml
9892

99-
undeploy-dev-environment: undeploy-venice undeploy-kafka undeploy-flink undeploy
93+
undeploy-dev-environment: undeploy-venice undeploy-kafka undeploy-flink undeploy-demo undeploy
10094
kubectl delete -f ./deploy/dev || echo "skipping"
101-
kubectl delete -f ./deploy/samples/demodb.yaml || echo "skipping"
10295

10396
# Integration test setup intended to be run locally
10497
integration-tests: deploy-dev-environment
@@ -141,4 +134,4 @@ run-zeppelin: build-zeppelin
141134
--name hoptimator-zeppelin \
142135
hoptimator-zeppelin
143136

144-
.PHONY: install test build bounce clean quickstart deploy-config undeploy-config deploy undeploy deploy-samples undeploy-samples deploy-flink undeploy-flink deploy-kafka undeploy-kafka deploy-venice undeploy-venice build-zeppelin run-zeppelin integration-tests integration-tests-kind deploy-dev-environment undeploy-dev-environment generate-models release
137+
.PHONY: install test build bounce clean quickstart deploy-config undeploy-config deploy undeploy deploy-demo undeploy-demo deploy-flink undeploy-flink deploy-kafka undeploy-kafka deploy-venice undeploy-venice build-zeppelin run-zeppelin integration-tests integration-tests-kind deploy-dev-environment undeploy-dev-environment generate-models release

README.md

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
11
# Hoptimator
22

3+
## Prerequisite
4+
Hoptimator by default requires a Kubernetes cluster to operate. To set up a local dev environment, you can follow the steps below:
5+
6+
1. Install Docker for Desktop
7+
2. Navigate to Docker Settings -> Kubernetes -> Select Enable Kubernetes
8+
3. Run: kubectl config use-context docker-desktop
9+
10+
Alternatively you can use [kind](https://kind.sigs.k8s.io/) to create a local cluster.
11+
312
## Intro
413

514
Hoptimator gives you a SQL interface to a Kubernetes cluster. You can install databases, query tables, create views, and deploy data pipelines using just SQL.
@@ -42,8 +51,8 @@ Hoptimator requires a Kubernetes cluster. To connect from outside a Kubernetes c
4251
The below setup will install two local demo DBs, ads and profiles.
4352

4453
```
45-
$ make install # build and install SQL CLI
46-
$ make deploy deploy-demo # install demo DB CRDs and K8s objects
54+
$ make build install # build and install SQL CLI
55+
$ make deploy-demo # install demo DB CRDs and K8s objects
4756
$ ./hoptimator # start the SQL CLI
4857
> !intro
4958
```
@@ -53,7 +62,7 @@ The below setup will install two local demo DBs, ads and profiles.
5362
The below setup will create a dev environment with various resources within Kubernetes.
5463

5564
```
56-
$ make install # build and install SQL CLI
65+
$ make build install # build and install SQL CLI
5766
$ make deploy-dev-environment # start all local dev setups
5867
$ kubectl port-forward -n kafka svc/one-kafka-external-bootstrap 9092 & # forward external Kafka port for use by SQL CLI
5968
$ ./hoptimator # start the SQL CLI

0 commit comments

Comments
 (0)