Skip to content

Commit eeeb95f

Browse files
committed
handle failing test
1 parent 9b56fb1 commit eeeb95f

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

core/src/main/java/com/linecorp/armeria/internal/server/annotation/AnnotatedServiceLogUtil.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,18 @@ public final class AnnotatedServiceLogUtil {
5555

5656
public static void customize(ObjectMapper objectMapper) {
5757
final SimpleModule module = new SimpleModule("annotated-service-logging");
58-
for (Class<?> clazz : wellKnownTypes) {
59-
module.addSerializer(clazz, new ToStringSerializer(clazz));
60-
}
58+
customizeWellKnownSerializers(module);
6159
module.addSerializer(new AnnotatedRequestJsonSerializer());
6260
module.addSerializer(new AnnotatedResponseJsonSerializer());
6361
objectMapper.registerModule(module);
6462
}
6563

64+
public static void customizeWellKnownSerializers(SimpleModule module) {
65+
for (Class<?> clazz : wellKnownTypes) {
66+
module.addSerializer(clazz, new ToStringSerializer(clazz));
67+
}
68+
}
69+
6670
@Nullable
6771
static Object maybeUnwrapFuture(@Nullable Object param) {
6872
if (param == null) {

core/src/main/java/com/linecorp/armeria/internal/server/annotation/BeanFieldMaskerSelectorProvider.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
package com.linecorp.armeria.internal.server.annotation;
1818

19+
import static com.linecorp.armeria.internal.server.annotation.AnnotatedServiceLogUtil.customizeWellKnownSerializers;
20+
1921
import java.util.List;
2022

2123
import com.fasterxml.jackson.databind.ObjectMapper;
@@ -46,6 +48,7 @@ public void customize(List<BeanFieldMaskerSelector> selectors, ObjectMapper obje
4648
module.setDeserializerModifier(new MaskingBeanDeserializerModifier(maskerCache));
4749
module.addSerializer(new AnnotatedRequestJsonSerializer(maskerCache));
4850
module.addSerializer(new AnnotatedResponseJsonSerializer(maskerCache));
51+
customizeWellKnownSerializers(module);
4952
objectMapper.registerModule(module);
5053
// default to logging "{}" instead of throwing an exception for beans not intended for jackson
5154
objectMapper.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);

core/src/test/java/com/linecorp/armeria/common/logging/masker/it/BeanContentSanitizerITTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,8 @@ public CompletableFuture<SimpleFoo> hello(SimpleFoo foo, @Param String param, Ht
250250
.node("params[12]").isEqualTo("optionalParamValue")
251251
.node("params[13]").matches(new StringContains("param=paramValue"))
252252
.node("params[14]").isStringEqualTo("[]")
253-
.node("params[15]").matches(new StringContains(":method=POST"))
254-
.node("params[16]").matches(new StringContains(":method=POST"));
253+
.node("params[15].:method").isStringEqualTo("POST")
254+
.node("params[16].:method").isStringEqualTo("POST");
255255

256256
final String responseLog = logWriter.blockingDeque().takeFirst();
257257
matcher = responseContentPattern.matcher(responseLog);

0 commit comments

Comments
 (0)