feat: remove DepositUpdated and YangTotalUpdated events (#585)

Author: tserg

src/core/shrine.cairo

@@ -246,7 +246,6 @@ pub mod shrine {
     pub enum Event {
         AccessControlEvent: access_control_component::Event,
         YangAdded: YangAdded,
-        YangTotalUpdated: YangTotalUpdated,
         TotalTrovesDebtUpdated: TotalTrovesDebtUpdated,
         ProtocolOwnedTrovesDebtUpdated: ProtocolOwnedTrovesDebtUpdated,
         BudgetAdjusted: BudgetAdjusted,
@@ -260,7 +259,6 @@ pub mod shrine {
         Melt: Melt,
         Charge: Charge,
         TroveRedistributed: TroveRedistributed,
-        DepositUpdated: DepositUpdated,
         YangPriceUpdated: YangPriceUpdated,
         YinPriceUpdated: YinPriceUpdated,
         MinimumTroveValueUpdated: MinimumTroveValueUpdated,
@@ -281,13 +279,6 @@ pub mod shrine {
         pub initial_rate: Ray
     }
 
-    #[derive(Copy, Drop, starknet::Event, PartialEq)]
-    pub struct YangTotalUpdated {
-        #[key]
-        pub yang: ContractAddress,
-        pub total: Wad
-    }
-
     #[derive(Copy, Drop, starknet::Event, PartialEq)]
     pub struct TotalTrovesDebtUpdated {
         pub total: Wad
@@ -375,15 +366,6 @@ pub mod shrine {
         pub debt: Wad
     }
 
-    #[derive(Copy, Drop, starknet::Event, PartialEq)]
-    pub struct DepositUpdated {
-        #[key]
-        pub yang: ContractAddress,
-        #[key]
-        pub trove_id: u64,
-        pub amount: Wad
-    }
-
     #[derive(Copy, Drop, starknet::Event, PartialEq)]
     pub struct YangPriceUpdated {
         #[key]
@@ -724,7 +706,6 @@ pub mod shrine {
 
             // Event emissions
             self.emit(YangAdded { yang, yang_id, start_price, initial_rate });
-            self.emit(YangTotalUpdated { yang, total: initial_yang_amt });
         }
 
         fn set_threshold(ref self: ContractState, yang: ContractAddress, new_threshold: Ray) {
@@ -974,10 +955,6 @@ pub mod shrine {
             // Update trove balance
             let new_trove_balance: Wad = self.deposits.read((yang_id, trove_id)) + amount;
             self.deposits.write((yang_id, trove_id), new_trove_balance);
-
-            // Events
-            self.emit(YangTotalUpdated { yang, total: new_total });
-            self.emit(DepositUpdated { yang, trove_id, amount: new_trove_balance });
         }
 
         // Withdraw a specified amount of a Yang from a Trove with trove safety check
@@ -1567,10 +1544,6 @@ pub mod shrine {
 
             self.yang_total.write(yang_id, new_total);
             self.deposits.write((yang_id, trove_id), new_trove_balance);
-
-            // Emit events
-            self.emit(YangTotalUpdated { yang, total: new_total });
-            self.emit(DepositUpdated { yang, trove_id, amount: new_trove_balance });
         }
 
         // Adds the accumulated interest as debt to the trove

src/tests/shrine/test_shrine.cairo

@@ -399,12 +399,6 @@ mod test_shrine {
                     }
                 )
             ),
-            (
-                shrine.contract_address,
-                shrine_contract::Event::YangTotalUpdated(
-                    shrine_contract::YangTotalUpdated { yang: new_yang_address, total: Zero::zero() }
-                )
-            ),
         ];
 
         spy.assert_emitted(@expected_events);
@@ -865,7 +859,6 @@ mod test_shrine {
     #[test]
     fn test_shrine_deposit_pass() {
         let shrine: IShrineDispatcher = shrine_utils::shrine_setup_with_feed(Option::None);
-        let mut spy = spy_events(SpyOn::One(shrine.contract_address));
 
         let deposit_amt: Wad = shrine_utils::TROVE1_YANG1_DEPOSIT.into();
         shrine_utils::trove1_deposit(shrine, deposit_amt);
@@ -892,23 +885,6 @@ mod test_shrine {
         assert(max_forge_amt == expected_max_forge, 'incorrect max forge amt');
 
         shrine_utils::assert_total_yang_invariant(shrine, yangs, 1);
-
-        let expected_events = array![
-            (
-                shrine.contract_address,
-                shrine_contract::Event::YangTotalUpdated(
-                    shrine_contract::YangTotalUpdated { yang, total: deposit_amt, }
-                )
-            ),
-            (
-                shrine.contract_address,
-                shrine_contract::Event::DepositUpdated(
-                    shrine_contract::DepositUpdated { yang, trove_id, amount: deposit_amt, }
-                )
-            ),
-        ];
-
-        spy.assert_emitted(@expected_events);
     }
 
     #[test]
@@ -936,7 +912,6 @@ mod test_shrine {
     #[test]
     fn test_shrine_withdraw_pass() {
         let shrine: IShrineDispatcher = shrine_utils::shrine_setup_with_feed(Option::None);
-        let mut spy = spy_events(SpyOn::One(shrine.contract_address));
 
         start_prank(CheatTarget::All, shrine_utils::admin());
 
@@ -968,23 +943,6 @@ mod test_shrine {
         assert(max_forge_amt == expected_max_forge, 'incorrect max forge amt');
 
         shrine_utils::assert_total_yang_invariant(shrine, yangs, 1);
-
-        let expected_events = array![
-            (
-                shrine.contract_address,
-                shrine_contract::Event::YangTotalUpdated(
-                    shrine_contract::YangTotalUpdated { yang: yang1_addr, total: remaining_amt }
-                )
-            ),
-            (
-                shrine.contract_address,
-                shrine_contract::Event::DepositUpdated(
-                    shrine_contract::DepositUpdated { yang: yang1_addr, trove_id, amount: remaining_amt }
-                )
-            ),
-        ];
-
-        spy.assert_emitted(@expected_events);
     }
 
     #[test]