Skip to content

Set up proper testing infrastructure #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
javra opened this issue Dec 6, 2023 · 3 comments
Open

Set up proper testing infrastructure #9

javra opened this issue Dec 6, 2023 · 3 comments

Comments

@javra
Copy link
Collaborator

javra commented Dec 6, 2023

Maybe see how mathlib4 and std4 run their tests.

@RaitoBezarius
Copy link
Contributor

@javra So what I propose to this is:

(a) We can do the nightly testing branch where we bump all our dependencies, e.g. Lean 4 and Mathlib4 and run the tests over there and we can be pinged when the pipeline fails. (what Std4 does.)
(b) We can add something like Bors (Bors is deprecated though in favor of GitHub Merge Queues but they are not super nice), we can use https://mergify.com/alternative/github-merge-queue instead.
(c) We can adopt the classical labelling mechanism that those projects uses (awaiting for review, awaiting for author, merge conflict, etc.)

The rest of the files here:
https://github.com/leanprover-community/mathlib4/tree/master/.github/workflows

seems to be quite specific to the scale of Mathlib4, I'd say?

@RaitoBezarius
Copy link
Contributor

Maybe, we can keep staying on a specific Lean 4 version though.

@javra
Copy link
Collaborator Author

javra commented Dec 8, 2023

I'm not against bumping everything manually and just giving all of us the power to merge instantly.

I think the most pressing thing is that we still test everything by just building the stuff, including commands that produce output, in Aegis.Tests and in mathlib they seem to have a solution where we have Foo.lean.expected.out files that are matched against the actual output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants