Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

tape.EnsembleFrame Repartition Doesn't Track Parent Ensemble #342

Closed
wilsonbb opened this issue Jan 5, 2024 · 0 comments · Fixed by #349
Closed

tape.EnsembleFrame Repartition Doesn't Track Parent Ensemble #342

wilsonbb opened this issue Jan 5, 2024 · 0 comments · Fixed by #349
Assignees
Labels
bug Something isn't working

Comments

@wilsonbb
Copy link
Collaborator

wilsonbb commented Jan 5, 2024

Currently tape.EnsembleFrame.repartition returns an EnsembleFrame with an empty ensemble field. This results in EnsembleFrame.update_ensemble being a no-op instead of updating the parent ensemble to have the resulting frame.

This can be easily fixed by overriding repartition in the _Frame parent class and calling _propagate_metadata

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant