fix: code clean up

Author: Tarens2

src/common/consensus-provider/consensus-client.service.ts

@@ -2,10 +2,10 @@ import { ConsensusProviderService } from './index';
 import { Injectable } from '@nestjs/common';
 import { processJsonStreamBeaconState } from './utils/process-json-stream-beacon-state';
 import { BeaconState } from './consensus-provider.types';
+import { API_GET_STATE_URL } from './consensus-provider.constants';
 
 @Injectable()
 export class ConsensusClientService {
-  private API_GET_STATE = (stateId: string) => `/eth/v2/debug/beacon/states/${stateId}`;
   constructor(protected readonly consensusService: ConsensusProviderService) {}
 
   public async isElectraActivated(epoch: number) {
@@ -14,7 +14,7 @@ export class ConsensusClientService {
   }
 
   public async getStateStream(stateId: string): Promise<BeaconState> {
-    const stream = await this.consensusService.fetchStream(this.API_GET_STATE(stateId));
+    const stream = await this.consensusService.fetchStream(API_GET_STATE_URL(stateId));
     const result = await processJsonStreamBeaconState(stream);
     return result as BeaconState;
   }

src/common/consensus-provider/consensus-provider.constants.ts

@@ -4,3 +4,5 @@ export const CONSENSUS_RETRY_DELAY = 1_000;
 export const CONSENSUS_RETRY_ATTEMPTS = 3;
 
 export const CONSENSUS_REQUEST_TIMEOUT = 1800_000;
+
+export const API_GET_STATE_URL = (stateId: string) => `/eth/v2/debug/beacon/states/${stateId}`;

src/common/sweep/sweep.service.ts

@@ -1,26 +1,26 @@
+import { ethers } from 'ethers';
 import { Inject, Injectable, LoggerService } from '@nestjs/common';
 import { LOGGER_PROVIDER } from '@lido-nestjs/logger';
-import { SLOTS_PER_EPOCH } from '../genesis-time';
+import { SimpleFallbackJsonRpcBatchProvider } from '@lido-nestjs/execution';
+import { ConfigService } from 'common/config';
 import {
   isFullyWithdrawableValidator,
   isPartiallyWithdrawableValidator,
-} from '../../jobs/validators/utils/validator-state-utils';
-import { FAR_FUTURE_EPOCH } from '../../jobs/validators';
-import { ConsensusClientService } from '../consensus-provider/consensus-client.service';
-import { parseGwei } from '../utils/parse-gwei';
-import { bigNumberMin } from '../utils/big-number-min';
-import { Withdrawal } from './sweep.types';
-import { BeaconState, IndexedValidator, Validator } from '../consensus-provider/consensus-provider.types';
-import { ethers } from 'ethers';
-import { OracleV2__factory } from '../contracts/generated';
-import { VALIDATORS_EXIT_BUS_ORACLE_CONTRACT_ADDRESSES } from '../contracts/modules/validators-exit-bus-oracle/validators-exit-bus-oracle.constants';
-import { ConfigService } from '../config';
-import { SimpleFallbackJsonRpcBatchProvider } from '@lido-nestjs/execution';
+} from 'jobs/validators/utils/validator-state-utils';
+import { ConsensusClientService } from 'common/consensus-provider/consensus-client.service';
+import { BeaconState, IndexedValidator, Validator } from 'common/consensus-provider/consensus-provider.types';
+import { parseGwei } from 'common/utils/parse-gwei';
+import { bigNumberMin } from 'common/utils/big-number-min';
+import { OracleV2__factory } from 'common/contracts/generated';
+import { FAR_FUTURE_EPOCH } from 'jobs/validators';
+import { SLOTS_PER_EPOCH } from 'common/genesis-time';
+import { VALIDATORS_EXIT_BUS_ORACLE_CONTRACT_ADDRESSES } from 'common/contracts/modules/validators-exit-bus-oracle/validators-exit-bus-oracle.constants';
 import {
   MAX_PENDING_PARTIALS_PER_WITHDRAWALS_SWEEP,
   MAX_WITHDRAWALS_PER_PAYLOAD,
   MIN_ACTIVATION_BALANCE,
-} from '../../waiting-time/waiting-time.constants';
+} from 'waiting-time/waiting-time.constants';
+import { Withdrawal } from './sweep.types';
 
 @Injectable()
 export class SweepService {

src/storage/validators/validators-cache.service.ts

@@ -11,6 +11,7 @@ export class ValidatorsCacheService {
   static CACHE_FILE_NAME = 'validators-state.txt';
   static CACHE_DIR = 'cache';
   static CACHE_DATA_DIVIDER = '|';
+  static CACHE_DATA_LENGTH = 5;
   static SERVICE_LOG_NAME = 'validators cache';
   static CACHE_INVALIDATE_TIME = 3 * 3600; // 3 hours
 
@@ -30,7 +31,7 @@ export class ValidatorsCacheService {
       await file.close();
       const data: string[] = fileReadResult.split(ValidatorsCacheService.CACHE_DATA_DIVIDER);
 
-      if (data.length !== 5) {
+      if (data.length !== ValidatorsCacheService.CACHE_DATA_LENGTH) {
         this.logger.log(`invalid cache data length`, {
           service: ValidatorsCacheService.SERVICE_LOG_NAME,
           data,