This repository was archived by the owner on Apr 24, 2023. It is now read-only.
add 'node-pre-gyp' installation to 'check' and 'test-node' actions #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogdb
changed the title
wemeetagain
approved these changes
Mar 14, 2022
|
I can't manage Windows CI to pass. Please advice if you can. |
|
It looks like windows installation problem with node-pre-gyp |
Yeah. This I understand but I have no clue why it happens. The package author recommends to switch to |
vogdb
changed the title
|
Ok, it's ready. Please squash the PR when merging. |
|
@vasco-santos thank you. I see that CI failed on the merged PR. |
|
@achingbrain can you please setup token? I think we also need NPM token? |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
## [1.0.0](v0.7.1...v1.0.0) (2022-03-28) ### ⚠ BREAKING CHANGES * this module is now ESM-only Co-authored-by: achingbrain <[email protected]> ### Features * convert to typescript ([#151](#151)) ([85ce5cf](85ce5cf)) ### Bug Fixes * add 'node-pre-gyp' installation to 'check' and 'test-node' actions ([#152](#152)) ([bf4a68b](bf4a68b)) ### Trivial Changes * add note about `node-pre-gyp` to readme.md ([#141](#141)) ([ab4cc82](ab4cc82)), closes [#140](#140) * **deps-dev:** bump aegir from 35.2.1 to 36.0.0 ([#139](#139)) ([720cfad](720cfad)) * replace Travis with Github Actions ([#150](#150)) ([a73735b](a73735b)) * update project config ([13ab340](13ab340)) * update Readme ([#148](#148)) ([ba9facb](ba9facb))
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @vasco-santos