Skip to content

"autorelay (relay finder)" is a slow consumer of event.EvtPeerConnectednessChanged #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lidel opened this issue Dec 12, 2024 · 1 comment · Fixed by #3105
Closed

"autorelay (relay finder)" is a slow consumer of event.EvtPeerConnectednessChanged #3100

lidel opened this issue Dec 12, 2024 · 1 comment · Fixed by #3105
Assignees
@sukunrt
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@lidel
Copy link
Member

lidel commented Dec 12, 2024

found in log while testing kubo with latest go-libp2p master, node was running for ~18h since 2024-12-12T02:43:42.708Z):

  • 2024-12-12T20:22:19.142Z ERROR eventbus eventbus/basic.go:467 subscriber named "autorelay (relay finder)" is a slow consumer of event.EvtPeerConnectednessChanged. This can lead to libp2p stalling and hard to debug issues.
@lidel lidel added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Dec 12, 2024
@lidel
Copy link
Member Author

lidel commented Dec 12, 2024 •
edited
Loading

I had no time to look into this, and not sure if relevant to the above bug, but Kubo has this awkward way of feeding peers to libp2p relay code:

iirc libp2p.EnableAutoRelayWithPeerSource was provisional(?) way to bootstrap relay finder that was never changed.

@p-shahi p-shahi mentioned this issue Dec 16, 2024
Closed
26 tasks
@p-shahi p-shahi removed the need/triage Needs initial labeling and prioritization label Dec 16, 2024
@MarcoPolo MarcoPolo linked a pull request Dec 17, 2024 that will close this issue
fix(autorelay): Move relayFinder peer disconnect cleanup to separate goroutine #3105
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sukunrt sukunrt

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(autorelay): Move relayFinder peer disconnect cleanup to separate goroutine libp2p/go-libp2p
3 participants
@lidel @sukunrt @p-shahi