Skip to content

find relays stuck while retry #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
optman opened this issue Mar 16, 2022 · 2 comments
Closed

find relays stuck while retry #1359

optman opened this issue Mar 16, 2022 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP

Comments

@optman
Copy link
Contributor

optman commented Mar 16, 2022

go-libp2p/p2p/host/autorelay/autorelay.go

Line 294 in 13d0381

timer := time.NewTimer(30 * time.Second)

It should be NewTicker, otherwise it only fire once, and retry will stuck.
@marten-seemann
Copy link
Contributor

Good thing is this code will go away very soon, as I'm working #1351 right now.

@marten-seemann marten-seemann added kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP labels Mar 18, 2022
@marten-seemann
Copy link
Contributor

#1351 was merged, so this issue is moot now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marten-seemann @optman