Skip to content

Commit 853011a

Browse files
authored
tcp: ensure tcpGatedMaListener wrapping happens always (#3275)
1 parent 97f29c5 commit 853011a

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

p2p/transport/tcp/tcp.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -331,11 +331,16 @@ func (t *TcpTransport) Listen(laddr ma.Multiaddr) (transport.Listener, error) {
331331
list = t.upgrader.GateMaListener(mal)
332332
}
333333

334+
// Always wrap the listener with tcpGatedMaListener to apply TCP-specific configurations
335+
tcpList := &tcpGatedMaListener{list, 0}
336+
334337
if t.enableMetrics {
335-
// TODO: Fix this: The tcpListener wrapping should happen on both enableMetrics and disabledMetrics path
336-
list = newTracingListener(&tcpGatedMaListener{list, 0}, t.metricsCollector)
338+
// Wrap with tracing listener if metrics are enabled
339+
return t.upgrader.UpgradeGatedMaListener(t, newTracingListener(tcpList, t.metricsCollector)), nil
337340
}
338-
return t.upgrader.UpgradeGatedMaListener(t, list), nil
341+
342+
// Regular path without metrics
343+
return t.upgrader.UpgradeGatedMaListener(t, tcpList), nil
339344
}
340345

341346
// Protocols returns the list of terminal protocols this transport can dial.

0 commit comments

Comments
 (0)