Skip to content

flaky TestFindPeerQueryMinimal test #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcoPolo opened this issue Aug 30, 2022 · 2 comments · Fixed by #1020 or #1036
Closed

flaky TestFindPeerQueryMinimal test #791

MarcoPolo opened this issue Aug 30, 2022 · 2 comments · Fixed by #1020 or #1036
Labels
kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/test Testing work

Comments

@MarcoPolo
Copy link
Contributor

https://github.com/libp2p/go-libp2p-kad-dht/runs/8074038620?check_suite_focus=true

@lidel
Copy link
Member

lidel commented Dec 11, 2022

@lidel lidel added kind/bug A bug in existing code (including security flaws) kind/test Testing work kind/maintenance Work required to avoid breaking changes or harm to project's status quo labels Dec 11, 2022
@lidel lidel added this to go-libp2p Dec 11, 2022
@lidel lidel moved this to 🥞 Todo in go-libp2p Dec 11, 2022
@lidel lidel added the need/triage Needs initial labeling and prioritization label Dec 11, 2022
@github-project-automation github-project-automation bot moved this from 🥞 Todo to 🎉 Done in go-libp2p Feb 7, 2025
@guillaumemichel
Copy link
Contributor

guillaumemichel commented Feb 18, 2025

=== RUN   TestFindPeerQueryMinimal
    dht_test.go:1663: connecting
    dht_test.go:1678: waiting for routing tables
    dht_test.go:1681: avg rt size: 1
    dht_test.go:1683: refreshing
    dht_test.go:1696: waiting for routing tables again
    dht_test.go:1699: avg rt size: 13
    dht_test.go:1706: querying
    dht_test.go:1717: got 4 peers
    dht_test.go:1720: 
        	Error Trace:	/home/runner/work/go-libp2p-kad-dht/go-libp2p-kad-dht/dht_test.go:1720
        	            				/home/runner/work/go-libp2p-kad-dht/go-libp2p-kad-dht/dht_test.go:1628
        	Error:      	Not equal: 
        	            	expected: []peer.ID{"\x00$\b\x01\x12 \x89\xb79\x06D\xdc\xe9\x91\x16\xb6\xc0\xb7\xe9\xf2\xd5\x02$T\xe6\x95\xc4~\xa2\xc9\xcfw\xf2\nt\x15\x83\xa2", "\x00$\b\x01\x12 }o\xe8g\xf5S\xfa\x15\xc9\xf42\xa3\x059\xb1\x8d'\x843\x92\xf2\xf5l\x9aL\x85b\xdd\xd5\xc6\xd6\xe4", "\x00$\b\x01\x12 \xd9H\x04\x9c KR\xbcj\xef\xfca\x87\x82\xe0D\xb2\b\x91\xb4H\xc9]c;j\xe4J\xffB\x7f\xb1", "\x00$\b\x01\x12 \xfdi_\xcc7\xdc\xe9\xef\xc9\xd7.T\x9e\x88\x8fpn\x98\xaf\x1b\xdeկ\x00\x13K\xdd\xe2\xae\\M\xbd"}
        	            	actual  : []peer.ID{"\x00$\b\x01\x12 \x89\xb79\x06D\xdc\xe9\x91\x16\xb6\xc0\xb7\xe9\xf2\xd5\x02$T\xe6\x95\xc4~\xa2\xc9\xcfw\xf2\nt\x15\x83\xa2", "\x00$\b\x01\x12 }o\xe8g\xf5S\xfa\x15\xc9\xf42\xa3\x059\xb1\x8d'\x843\x92\xf2\xf5l\x9aL\x85b\xdd\xd5\xc6\xd6\xe4", "\x00$\b\x01\x12 \xd9H\x04\x9c KR\xbcj\xef\xfca\x87\x82\xe0D\xb2\b\x91\xb4H\xc9]c;j\xe4J\xffB\x7f\xb1", "\x00$\b\x01\x12 S\xda\r\xe9S\xaa\xa6\x93YHnA\x01\xf9\x98\x8a@\x97\xd3\xfc\x85\f\x1f\x10\x99\x02\x10\x8a\xce\xc4\x14I"}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -4,3 +4,3 @@
        	            	  (peer.ID) (len=38) "\x00$\b\x01\x12 \xd9H\x04\x9c KR\xbcj\xef\xfca\x87\x82\xe0D\xb2\b\x91\xb4H\xc9]c;j\xe4J\xffB\x7f\xb1",
        	            	- (peer.ID) (len=38) "\x00$\b\x01\x12 \xfdi_\xcc7\xdc\xe9\xef\xc9\xd7.T\x9e\x88\x8fpn\x98\xaf\x1b\xdeկ\x00\x13K\xdd\xe2\xae\\M\xbd"
        	            	+ (peer.ID) (len=38) "\x00$\b\x01\x12 S\xda\r\xe9S\xaa\xa6\x93YHnA\x01\xf9\x98\x8a@\x97\xd3\xfc\x85\f\x1f\x10\x99\x02\x10\x8a\xce\xc4\x14I"
        	            	 }
        	Test:       	TestFindPeerQueryMinimal
--- FAIL: TestFindPeerQueryMinimal (0.71s)

https://github.com/libp2p/go-libp2p-kad-dht/actions/runs/13393421725/job/37411369286?pr=1032#step:13:238

@github-project-automation github-project-automation bot moved this from 🎉 Done to 🥞 Todo in go-libp2p Feb 18, 2025
@guillaumemichel guillaumemichel removed the need/triage Needs initial labeling and prioritization label Feb 18, 2025
@github-project-automation github-project-automation bot moved this from 🥞 Todo to 🎉 Done in go-libp2p Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/test Testing work
Projects
Status: 🎉 Done
3 participants