fix: flaky TestInvalidServer (#1049)

guillaumemichel · web-flow · commit dbc7a080cedc · 2025-02-21T15:11:32.000+01:00
diff --git a/dht_test.go b/dht_test.go
@@ -1559,8 +1559,9 @@ func TestInvalidServer(t *testing.T) {
 		t.Fatal("DHT server should have been added to the misbehaving server routing table")
 	}
 
-	// connect s0 to both s1 and m1
+	// connect s0 to s1 first and then m1
 	connectNoSync(t, ctx, s0, s1)
+	wait(t, ctx, s0, s1)
 	connectNoSync(t, ctx, s0, m1)
 
 	// s1 should be added to s0's routing table. Then, because s0's routing table

Original file line number	Diff line number	Diff line change
`@@ -1559,8 +1559,9 @@ func TestInvalidServer(t *testing.T) {`
`1559`	`1559`	`t.Fatal("DHT server should have been added to the misbehaving server routing table")`
`1560`	`1560`	`}`
`1561`	`1561`
`1562`		`- // connect s0 to both s1 and m1`
	`1562`	`+ // connect s0 to s1 first and then m1`
`1563`	`1563`	`connectNoSync(t, ctx, s0, s1)`
	`1564`	`+ wait(t, ctx, s0, s1)`
`1564`	`1565`	`connectNoSync(t, ctx, s0, m1)`
`1565`	`1566`
`1566`	`1567`	`// s1 should be added to s0's routing table. Then, because s0's routing table`