optimisation

Author: guillaumemichel

dht_net.go

@@ -100,7 +100,9 @@ func (dht *IpfsDHT) handleNewMessage(s network.Stream) bool {
 			metrics.ReceivedBytes.M(int64(msgLen)),
 		)
 
-		dht.onRequestHook(ctx, s, req)
+		if dht.onRequestHook != nil {
+			dht.onRequestHook(ctx, s, req)
+		}
 
 		handler := dht.handlerForMsgType(req.GetType())
 		if handler == nil {

dht_options.go

@@ -371,9 +371,10 @@ func WithCustomMessageSender(messageSenderBuilder func(h host.Host, protos []pro
 	}
 }
 
-// OnRequestHook registers a callback function that will be invoked
-// for every incoming DHT protocol message. Note: Ensure that the
-// callback executes efficiently, as it can block the entire message handler.
+// OnRequestHook registers a callback function that will be invoked for every
+// incoming DHT protocol message.
+// Note: Ensure that the callback executes efficiently, as it will block the
+// entire message handler.
 func OnRequestHook(f func(ctx context.Context, s network.Stream, req pb.Message)) Option {
 	return func(c *dhtcfg.Config) error {
 		c.OnRequestHook = f

internal/config/config.go

@@ -137,8 +137,6 @@ var Defaults = func(o *Config) error {
 	// MAGIC: It makes sense to set it to a multiple of OptProvReturnRatio * BucketSize. We chose a multiple of 4.
 	o.OptimisticProvideJobsPoolSize = 60
 
-	o.OnRequestHook = func(ctx context.Context, s network.Stream, req pb.Message) {}
-
 	return nil
 }