refactor: return nil instead of an empty record when processing an invalid record

aschmahmann · aschmahmann · commit 197ecaeb2cee · 2020-10-06T23:38:38.000-04:00
diff --git a/wire/messages.go b/wire/messages.go
@@ -104,8 +104,7 @@ func (pm *ProtocolMessenger) GetValue(ctx context.Context, p peer.ID, key string
 		if err != nil {
 			logger.Debug("received invalid record (discarded)")
 			// return a sentinel to signify an invalid record was received
-			err = internal.ErrInvalidRecord
-			rec = new(recpb.Record)
+			return nil, peers, internal.ErrInvalidRecord
 		}
 		return rec, peers, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -104,8 +104,7 @@ func (pm *ProtocolMessenger) GetValue(ctx context.Context, p peer.ID, key string`
`104`	`104`	`if err != nil {`
`105`	`105`	`logger.Debug("received invalid record (discarded)")`
`106`	`106`	`// return a sentinel to signify an invalid record was received`
`107`		`- err = internal.ErrInvalidRecord`
`108`		`- rec = new(recpb.Record)`
	`107`	`+ return nil, peers, internal.ErrInvalidRecord`
`109`	`108`	`}`
`110`	`109`	`return rec, peers, err`
`111`	`110`	`}`