Skip to content

Commit 2b2b169

Browse files
authored
Merge pull request #1160 from libcpr/fix/vs19-nuget-compatibility
Fix/vs19 nuget compatibility
2 parents 3591f20 + 4f51f71 commit 2b2b169

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/build-nuget.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ on:
1414

1515
jobs:
1616
package-windows-latest:
17-
runs-on: windows-latest
17+
runs-on: windows-2019
1818
steps:
1919
- name: Set version based on input
2020
if: ${{ inputs.version }}
@@ -32,7 +32,7 @@ jobs:
3232
uses: nuget/setup-nuget@v1
3333
- name: "[Release_x86] Build & Install"
3434
env:
35-
CMAKE_GENERATOR: "Visual Studio 17 2022"
35+
CMAKE_GENERATOR: "Visual Studio 16 2019"
3636
uses: ashutoshvarma/action-cmake-build@master
3737
with:
3838
build-dir: ${{github.workspace}}/build
@@ -49,7 +49,7 @@ jobs:
4949
run: rm -r -fo ${{github.workspace}}/build
5050
- name: "[Debug_x86] Build & Install"
5151
env:
52-
CMAKE_GENERATOR: "Visual Studio 17 2022"
52+
CMAKE_GENERATOR: "Visual Studio 16 2019"
5353
uses: ashutoshvarma/action-cmake-build@master
5454
with:
5555
build-dir: ${{github.workspace}}/build
@@ -66,7 +66,7 @@ jobs:
6666
run: rm -r -fo ${{github.workspace}}/build
6767
- name: "[Release_x64] Build & Install"
6868
env:
69-
CMAKE_GENERATOR: "Visual Studio 17 2022"
69+
CMAKE_GENERATOR: "Visual Studio 16 2019"
7070
uses: ashutoshvarma/action-cmake-build@master
7171
with:
7272
build-dir: ${{github.workspace}}/build
@@ -83,7 +83,7 @@ jobs:
8383
run: rm -r -fo ${{github.workspace}}/build
8484
- name: "[Debug_x64] Build & Install"
8585
env:
86-
CMAKE_GENERATOR: "Visual Studio 17 2022"
86+
CMAKE_GENERATOR: "Visual Studio 16 2019"
8787
uses: ashutoshvarma/action-cmake-build@master
8888
with:
8989
build-dir: ${{github.workspace}}/build

nuget/libcpr.nuspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<id>libcpr</id>
55
<version>$VERSION$</version>
66
<title>C++ Requests: Curl for People</title>
7-
<authors>Simon Berger</authors>
7+
<authors>Fabian Sauter</authors>
88
<owners>Fabian Sauter, Kilian Traub, many other libcpr contributors</owners>
99
<requireLicenseAcceptance>false</requireLicenseAcceptance>
1010
<license type="expression">MIT</license>

0 commit comments

Comments
 (0)