Skip to content

Commit dc9716b

Browse files
committed
Merge branch 'jorrit-floatingcontents'
2 parents 431e4d0 + 89b74a7 commit dc9716b

File tree

4 files changed

+47
-3
lines changed

4 files changed

+47
-3
lines changed

jquery.matchHeight.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,8 @@
191191
'margin-bottom': '0',
192192
'border-top-width': '0',
193193
'border-bottom-width': '0',
194-
'height': '100px'
194+
'height': '100px',
195+
'overflow': 'hidden'
195196
});
196197
});
197198

test/page/test.css

+16
Original file line numberDiff line numberDiff line change
@@ -304,4 +304,20 @@ a.test-summary.has-failed {
304304
display: inline-flex;
305305
vertical-align: top;
306306
float: none;
307+
}
308+
309+
/* test items-with-float */
310+
311+
.items-with-float .item-0 {
312+
float: none;
313+
width: auto;
314+
}
315+
316+
.items-with-float .item-0 .float-element {
317+
display: inline-block;
318+
float: left;
319+
width: 150px;
320+
height: 150px;
321+
margin: 0 20px 12px 0;
322+
background: #EB6841;
307323
}

test/page/test.html

+27
Original file line numberDiff line numberDiff line change
@@ -345,6 +345,33 @@ <h3>Target</h3>
345345
</div>
346346
</div>
347347
</div>
348+
349+
<div class="items-container items-with-float">
350+
<div class="item item-0">
351+
<div class="float-element"></div>
352+
<h3>Floating element</h3>
353+
<p>Phasellus ut nibh fermentum, vulputate urna vel, semper diam.</p>
354+
<p>Aenean semper felis ipsum, vulputate consequat dui elementum vel.</p>
355+
<p>Phasellus ut nibh fermentum, vulputate urna vel, semper diam. Nunc sollicitudin felis ut pellentesque fermentum. In erat mi, pulvinar sit amet tincidunt vitae, gravida id felis. Phasellus hendrerit erat sed porta imperdiet. Vivamus viverra ipsum tortor, et congue mauris porttitor ut.</p>
356+
<p>Phasellus ut nibh fermentum, vulputate urna vel, semper diam. Nunc sollicitudin felis ut pellentesque fermentum. In erat mi, pulvinar sit amet tincidunt vitae, gravida id felis.</p>
357+
</div>
358+
<div class="item item-1">
359+
<h3>Lorem ipsum dolor</h3>
360+
<p>Phasellus ut nibh fermentum, vulputate urna vel, semper diam. Nunc sollicitudin felis ut pellentesque fermentum. In erat mi, pulvinar sit amet tincidunt vitae, gravida id felis.</p>
361+
</div>
362+
<div class="item item-2">
363+
<h3>Lorem ipsum dolor</h3>
364+
<p>Aenean semper felis ipsum, vulputate consequat dui elementum vel.</p>
365+
</div>
366+
<div class="item item-3">
367+
<h3>Lorem ipsum dolor</h3>
368+
<p>Aenean semper felis ipsum, vulputate consequat dui elementum vel. Nullam odio eros, sagittis vitae lectus id, pretium viverra lectus. Etiam auctor dolor non dui ultricies pulvinar.</p>
369+
</div>
370+
<div class="item item-4">
371+
<h3>Lorem ipsum dolor</h3>
372+
<p>Phasellus ut nibh fermentum, vulputate urna vel, semper diam.</p>
373+
</div>
374+
</div>
348375
</div>
349376
<div id='results'></div>
350377
</body>

test/specs/matchHeight.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ describe('matchHeight', function() {
106106
expect(1.0001).not.toBeWithinTolerance(0);
107107

108108
$('.simple-items, .image-items, .nested-items-parent, .nested-items,' +
109-
'.fixed-items, .inline-block-items, .inline-flex-items')
109+
'.fixed-items, .inline-block-items, .inline-flex-items, .items-with-float')
110110
.each(function() {
111111
var $items = $(this).children('.item'),
112112
rows = $.fn.matchHeight._rows($items);
@@ -147,7 +147,7 @@ describe('matchHeight', function() {
147147
$.fn.matchHeight._update();
148148

149149
$('.simple-items, .image-items,' +
150-
'.fixed-items, .inline-block-items, .inline-flex-items')
150+
'.fixed-items, .inline-block-items, .inline-flex-items, .items-with-float')
151151
.each(function() {
152152
var $items = $(this).children('.item'),
153153
targetHeight = $items.first().outerHeight(),

0 commit comments

Comments
 (0)