Set release in maven-compiler-plugin configuration and enforce JDK 11+ for compiling

Fixes apache#8445

- Sets release in maven-compiler-plugin configuration
  this results in passing "--release 8" flag to the javac compiler
  - ensures that correct methods are chosen in compilation.
    For example, without passing the flag, incorrect java.nio.ByteBuffer
    methods will be chosen in the case that compilation is performed on Java 9+
    and runtime uses Java 8. This results in NoSuchMethodErrors at runtime.

Author: lhotari

.github/workflows/ci-build-macos.yaml

@@ -54,10 +54,10 @@ jobs:
             !~/.m2/.gradle-enterprise
           key: ${{ runner.os }}-maven-dependencies-${{ hashFiles('**/pom.xml') }}
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         uses: actions/setup-java@v1
         with:
-          java-version: 1.8
+          java-version: 11
 
       - name: build package
         run: mvn clean install -DskipTests

.github/workflows/ci-cpp.yaml

@@ -58,11 +58,11 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-maven-
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         uses: actions/setup-java@v1
         if: steps.docs.outputs.changed_only == 'no'
         with:
-          java-version: 1.8
+          java-version: 11
 
       - name: clean disk
         if: steps.docs.outputs.changed_only == 'no'

.github/workflows/ci-integration-backwards-compatibility.yaml

@@ -57,11 +57,11 @@ jobs:
         with:
           args: site2 deployment .asf.yaml .ci ct.yaml
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         if: steps.docs.outputs.changed_only == 'no'
         uses: actions/setup-java@v1
         with:
-          java-version: 1.8
+          java-version: 11
 
       - name: clean disk
         if: steps.docs.outputs.changed_only == 'no'

.github/workflows/ci-integration-cli.yaml

@@ -57,11 +57,11 @@ jobs:
         with:
           args: site2 deployment .asf.yaml .ci ct.yaml
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         uses: actions/setup-java@v1
         if: steps.docs.outputs.changed_only == 'no'
         with:
-          java-version: 1.8
+          java-version: 11
 
       - name: clean disk
         if: steps.docs.outputs.changed_only == 'no'

.github/workflows/ci-integration-function-state.yaml

@@ -57,11 +57,11 @@ jobs:
         with:
           args: site2 deployment .asf.yaml .ci ct.yaml
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         uses: actions/setup-java@v1
         if: steps.docs.outputs.changed_only == 'no'
         with:
-          java-version: 1.8
+          java-version: 11
 
       - name: clean disk
         if: steps.docs.outputs.changed_only == 'no'

.github/workflows/ci-integration-messaging.yaml

@@ -57,11 +57,11 @@ jobs:
         with:
           args: site2 deployment .asf.yaml .ci ct.yaml
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         uses: actions/setup-java@v1
         if: steps.docs.outputs.changed_only == 'no'
         with:
-          java-version: 1.8
+          java-version: 11
 
       - name: clean disk
         if: steps.docs.outputs.changed_only == 'no'

.github/workflows/ci-integration-process.yaml

@@ -56,11 +56,11 @@ jobs:
         with:
           args: site2 deployment .asf.yaml .ci ct.yaml
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         uses: actions/setup-java@v1
         if: steps.docs.outputs.changed_only == 'no'
         with:
-          java-version: 1.8
+          java-version: 11
 
       - name: clean disk
         if: steps.docs.outputs.changed_only == 'no'

.github/workflows/ci-integration-schema.yaml

@@ -56,11 +56,11 @@ jobs:
         with:
           args: site2 deployment .asf.yaml .ci ct.yaml
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         uses: actions/setup-java@v1
         if: steps.docs.outputs.changed_only == 'no'
         with:
-          java-version: 1.8
+          java-version: 11
 
       - name: clean disk
         if: steps.docs.outputs.changed_only == 'no'

.github/workflows/ci-integration-sql.yaml

@@ -56,11 +56,11 @@ jobs:
         with:
           args: site2 deployment .asf.yaml .ci ct.yaml
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         uses: actions/setup-java@v1
         if: steps.docs.outputs.changed_only == 'no'
         with:
-          java-version: 1.8
+          java-version: 11
 
       - name: clean disk
         if: steps.docs.outputs.changed_only == 'no'

.github/workflows/ci-integration-standalone.yaml

@@ -56,11 +56,11 @@ jobs:
         with:
           args: site2 deployment .asf.yaml .ci ct.yaml
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         uses: actions/setup-java@v1
         if: steps.docs.outputs.changed_only == 'no'
         with:
-          java-version: 1.8
+          java-version: 11
 
       - name: clean disk
         if: steps.docs.outputs.changed_only == 'no'

.github/workflows/ci-integration-thread.yaml

@@ -56,11 +56,11 @@ jobs:
         with:
           args: site2 deployment .asf.yaml .ci ct.yaml
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         uses: actions/setup-java@v1
         if: steps.docs.outputs.changed_only == 'no'
         with:
-          java-version: 1.8
+          java-version: 11
 
       - name: clean disk
         if: steps.docs.outputs.changed_only == 'no'

.github/workflows/ci-integration-tiered-filesystem.yaml

@@ -56,11 +56,11 @@ jobs:
         with:
           args: site2 deployment .asf.yaml .ci ct.yaml
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         uses: actions/setup-java@v1
         if: steps.docs.outputs.changed_only == 'no'
         with:
-          java-version: 1.8
+          java-version: 11
 
       - name: clean disk
         if: steps.docs.outputs.changed_only == 'no'

.github/workflows/ci-integration-tiered-jcloud.yaml

@@ -56,11 +56,11 @@ jobs:
         with:
           args: site2 deployment .asf.yaml .ci ct.yaml
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         uses: actions/setup-java@v1
         if: steps.docs.outputs.changed_only == 'no'
         with:
-          java-version: 1.8
+          java-version: 11
 
       - name: clean disk
         if: steps.docs.outputs.changed_only == 'no'

.github/workflows/ci-integration-transaction.yaml

@@ -56,11 +56,11 @@ jobs:
         with:
           args: site2 deployment .asf.yaml .ci ct.yaml
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         uses: actions/setup-java@v1
         if: steps.docs.outputs.changed_only == 'no'
         with:
-          java-version: 1.8
+          java-version: 11
 
       - name: clean disk
         if: steps.docs.outputs.changed_only == 'no'

.github/workflows/ci-license.yaml

@@ -58,11 +58,11 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-maven-
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         if: steps.docs.outputs.changed_only == 'no'
         uses: actions/setup-java@v1
         with:
-          java-version: 1.8
+          java-version: 11
 
       # license check fails with 3.6.2 so we have to downgrade
       - name: Set up Maven

.github/workflows/ci-shade-test.yaml

@@ -57,11 +57,11 @@ jobs:
         with:
           args: site2 deployment .asf.yaml .ci ct.yaml
 
-      - name: Set up JDK 1.8
+      - name: Set up JDK 11
         uses: actions/setup-java@v1
         if: steps.docs.outputs.changed_only == 'no'
         with:
-          java-version: 1.8
+          java-version: 11
 
       - name: clean disk
         if: steps.docs.outputs.changed_only == 'no'

README.md

@@ -86,8 +86,7 @@ components in the Pulsar ecosystem, including connectors, adapters, and other la
 ## Build Pulsar
 
 Requirements:
- * Java 8 JDK (for building Pulsar)
-   * When building Pulsar on a higher version (higher than Java 8), the resulting artifacts are not compatible with Java 8 runtime because of some issues, such as [issue 8445](https://github.com/apache/pulsar/issues/8445).
+ * Java 11 JDK (for building Pulsar)
  * Maven 3.6.1+
 
 Compile and install:

buildtools/pom.xml

@@ -76,9 +76,9 @@
       </plugin>
       <plugin>
         <artifactId>maven-compiler-plugin</artifactId>
+        <version>3.8.1</version>
         <configuration>
-          <source>1.8</source>
-          <target>1.8</target>
+          <release>8</release>
         </configuration>
       </plugin>
     </plugins>

pom.xml

@@ -1065,8 +1065,7 @@ flexible messaging model and an intuitive client API.</description>
       <plugin>
         <artifactId>maven-compiler-plugin</artifactId>
         <configuration>
-          <source>1.8</source>
-          <target>1.8</target>
+          <release>8</release>
           <encoding>UTF-8</encoding>
           <showDeprecation>true</showDeprecation>
           <showWarnings>true</showWarnings>
@@ -1332,16 +1331,17 @@ flexible messaging model and an intuitive client API.</description>
         <executions>
             <execution>
                 <id>enforce-maven</id>
+                <phase>validate</phase>
                 <goals>
                     <goal>enforce</goal>
                 </goals>
               <configuration>
                 <rules>
                   <requireJavaVersion>
-                    <version>[1.8.0,)</version>
+                    <version>[11,)</version>
                   </requireJavaVersion>
                   <requireMavenVersion>
-                    <version>[3.3.9,)</version>
+                    <version>[3.6.1,)</version>
                   </requireMavenVersion>
                 </rules>
               </configuration>