Merge pull request #281 from LeeNX/leenx-add-comment-memcmp

lemmingDev · web-flow · commit a93b516029c8 · 2025-04-28T06:48:49.000+09:00
Add comment back of readable if statement
diff --git a/examples/Fightstick/Fightstick.ino b/examples/Fightstick/Fightstick.ino
@@ -124,6 +124,8 @@ void loop()
         bleGamepad.setHats(hatValues[0], hatValues[1], hatValues[2], hatValues[3]);
 
         // Update previous states to current states and send report
+        // readable, but with compiler warning:
+        //  if (currentButtonStates != previousButtonStates || currentHatStates != previousHatStates)
         if ((memcmp((const void *)currentButtonStates, (const void *)previousButtonStates, sizeof(currentButtonStates)) != 0) && (memcmp((const void *)currentHatStates, (const void *)previousHatStates, sizeof(currentHatStates)) != 0))
         {
             for (byte currentIndex = 0; currentIndex < numOfButtons; currentIndex++)

Original file line number	Diff line number	Diff line change
`@@ -124,6 +124,8 @@ void loop()`
`124`	`124`	`bleGamepad.setHats(hatValues[0], hatValues[1], hatValues[2], hatValues[3]);`
`125`	`125`
`126`	`126`	`// Update previous states to current states and send report`
	`127`	`+ // readable, but with compiler warning:`
	`128`	`+ // if (currentButtonStates != previousButtonStates \|\| currentHatStates != previousHatStates)`
`127`	`129`	`if ((memcmp((const void )currentButtonStates, (const void )previousButtonStates, sizeof(currentButtonStates)) != 0) && (memcmp((const void )currentHatStates, (const void )previousHatStates, sizeof(currentHatStates)) != 0))`
`128`	`130`	`{`
`129`	`131`	`for (byte currentIndex = 0; currentIndex < numOfButtons; currentIndex++)`