Do not ignore mismatched dependencies that do not report tags from the GitHub API

leighmcculloch · leighmcculloch · commit 872f6d2748e5 · 2019-08-30T00:20:54.000Z
diff --git a/main.go b/main.go
@@ -83,7 +83,7 @@ func run(depGopkgLockPath, goListModAllPath, githubAuthUsername, githubAuthPassw
 			tags, err := getTagsAndRevisions(ip, githubAuthUsername, githubAuthPassword)
 			if err != nil {
 				fmt.Fprintln(os.Stderr, "Error retrieving alternative tags:", err)
-			} else if tags[dep] == tags[mod] || tags[dep] == mod || tags[mod] == dep {
+			} else if len(tags) > 0 && (tags[dep] == tags[mod] || tags[dep] == mod || tags[mod] == dep) {
 				continue
 			}
 			fmt.Println("! ", ip, dep, "=>", mod)
diff --git a/testdata/1/output.txt b/testdata/1/output.txt
@@ -34,3 +34,10 @@ Added:
 Changed:
 !  github.com/onsi/ginkgo c73579c58881 => v1.7.0
 !  github.com/onsi/gomega 649b44d988ce => v1.4.3
+!  github.com/rcrowley/go-metrics a5cfc242a56b => cac0b30c2563
+!  golang.org/x/crypto 7f87c0fbb88b => cc06ce4a13d4
+!  golang.org/x/net 9bc2a3340c92 => 60506f45cf65
+!  golang.org/x/sys cc5685c2db12 => 5da285871e9c
+!  golang.org/x/text 1cbadb444a80 => v0.3.2
+!  gopkg.in/fatih/set.v0 57907de30022 => v0.1.0
+!  gopkg.in/yaml.v2 7ad95dd0798a => v2.2.2

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ func run(depGopkgLockPath, goListModAllPath, githubAuthUsername, githubAuthPassw`
`83`	`83`	`tags, err := getTagsAndRevisions(ip, githubAuthUsername, githubAuthPassword)`
`84`	`84`	`if err != nil {`
`85`	`85`	`fmt.Fprintln(os.Stderr, "Error retrieving alternative tags:", err)`
`86`		`- } else if tags[dep] == tags[mod] \|\| tags[dep] == mod \|\| tags[mod] == dep {`
	`86`	`+ } else if len(tags) > 0 && (tags[dep] == tags[mod] \|\| tags[dep] == mod \|\| tags[mod] == dep) {`
`87`	`87`	`continue`
`88`	`88`	`}`
`89`	`89`	`fmt.Println("! ", ip, dep, "=>", mod)`