Skip to content

Commit e21aee9

Browse files
committed
Compile files individually in CI
We just sprinkle some eval-when-compiles around for older Emacs. We can remove them when the CI no longer supports Emacs 25.1.
1 parent e1a9b8e commit e21aee9

File tree

6 files changed

+11
-1
lines changed

6 files changed

+11
-1
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
- name: Byte compilation
3838
run: emacs --eval "(setq byte-compile-error-on-warn (>= emacs-major-version 26))" -L . --batch -f batch-byte-compile ./*.el
3939
- name: Tests
40-
run: nix shell ${{ matrix.ledger_version || 'nixpkgs#ledger' }} --print-build-logs -c ./makem.sh test -vv --compile-batch
40+
run: nix shell ${{ matrix.ledger_version || 'nixpkgs#ledger' }} --print-build-logs -c ./makem.sh test -vv
4141
# This is currently for information only, since a lot of docstrings need fixing up
4242
- name: Checkdoc
4343
run: make lint-checkdoc || true

ledger-mode.el

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@
3030

3131
;;; Code:
3232

33+
(eval-when-compile
34+
(require 'subr-x)) ;for `when-let' in Emacs <26
3335
(require 'ledger-regex)
3436
(require 'org)
3537
(require 'ledger-commodities)

ledger-occur.el

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@
3030
;;; Code:
3131

3232
(require 'cl-lib)
33+
(eval-when-compile
34+
(require 'subr-x)) ;for `when-let' in Emacs <26
3335
(require 'ledger-navigate)
3436

3537
(defconst ledger-occur-overlay-property-name 'ledger-occur-custom-buffer-grep)

ledger-post.el

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
;;; Commentary:
2424
;; Utility functions for dealing with postings.
2525

26+
(eval-when-compile
27+
(require 'subr-x)) ;for `when-let', `string-empty-p', `string-trim' in Emacs <26
2628
(require 'ledger-regex)
2729
(require 'ledger-navigate)
2830

ledger-reconcile.el

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@
2727

2828
;;; Code:
2929

30+
(eval-when-compile
31+
(require 'subr-x)) ;`if-let', `when-let' in Emacs <26
3032
(require 'easymenu)
3133
(require 'ledger-init)
3234

ledger-xact.el

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525

2626
;;; Code:
2727

28+
(eval-when-compile
29+
(require 'subr-x)) ;`if-let', `when-let' in Emacs <26
2830
(require 'eshell)
2931
(require 'ledger-regex)
3032
(require 'ledger-navigate)

0 commit comments

Comments
 (0)