Skip to content

Fetch favicon from newsletter? #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
I7T5 opened this issue May 6, 2023 · 7 comments
Closed

Fetch favicon from newsletter? #92

I7T5 opened this issue May 6, 2023 · 7 comments

Comments

@I7T5
Copy link

I7T5 commented May 6, 2023

Is it possible to fetch favicon from the newsletter and use it instead of kill the newsletter's own favicon? I use kill the newsletter for NetNewsWire. Would be nice to have this feature.

@leafac
Copy link
Owner

leafac commented Jun 5, 2024

Hi @I7T5,

I love the idea, but there’s a complication: We don’t know which website is sending the newsletter. We could either ask the user to provide us with that information when creating the feed, or we could try to deduce that from the From fields on the emails that we receive.

In either case, I believe that the cost/benefit for creating and maintaining this feature isn’t there yet.

But I’ll keep that in mind and if more people keep asking for this then I may get around to it.

Best.

@leafac leafac closed this as completed Jun 5, 2024
@kutsan
Copy link

kutsan commented Jun 5, 2024

If it helps, I'm also eager for this feature to be implemented.

I think favicon should be retrieved from From fields for simplicity.

@leafac
Copy link
Owner

leafac commented Jun 6, 2024

Hmmm, alright, let’s give it a try. I implemented this as part of 2.0.6. It sets the <icon> based on the from of the email.

@Asmatzaile
Copy link

Thanks for the feature!
It doesn't always work for me; not all websites have the icon in root/favicon.ico. Also, if the mailing list doesn't accept kill the newsletter and a user tries to resend the message through their mail, this implementation won't work either.
Could you add a field in the 'feed created' page (where you can copy subscription and feed addresses) to optionally add a link to an image that can work as an icon?
That way, if the link is manually added, the feed could have the specified icon, and else, it could try to set it based on the from of the email, as it does now.

@leafac
Copy link
Owner

leafac commented Jun 15, 2024

@Asmatzaile: Thanks for the feedback.

I’ll look into that at some point…

@leafac
Copy link
Owner

leafac commented Jun 21, 2024

I added an option for you to set a custom icon. You may access it from a link at the bottom of the feed entries, as well as when you create the feed.

@chieft8
Copy link

chieft8 commented Aug 1, 2024

@Asmatzaile: Thanks for the feedback.

I’ll look into that at some point…

Have you successfully gotten to this to work on any newsletters? using on 5 of them, tried to clear caches, remove from reeder app and read, but never have gotten it to work. Tried many different image links as well. not sure what other information to add to help diagnose, but wondering if this is a me problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants