Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SistentComponents] Fix Hydtration Errors #6287

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

falgunmpatel
Copy link
Contributor

@falgunmpatel falgunmpatel commented Mar 8, 2025

Description

  • Implemented Proper nesting of <li> and <a> elements.
  • Removed default props from SEO Comonent due to deprecation warning from next update.
  • Moved named exports of section-nav, Header to new dedicatied components, as some warning were shown (see image below). Also they can be generalised to be reused in all other components (Generalization will be done in some other PR).

Also removed
Screenshot 2025-03-08 at 2 19 20 PM

This PR fixes #6286

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

…/index.js, as they can be genralised and reused in other components as well.

Signed-off-by: Falgun Patel <[email protected]>
- removed usage of defaultProps due to deprecation warnings for making it future safe.

Signed-off-by: Falgun Patel <[email protected]>
@l5io
Copy link
Contributor

l5io commented Mar 8, 2025

🚀 Preview for commit 80a61e8 at: https://67cc2bf0f7d773407946f5db--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

@falgunmpatel

Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST

adding it as an agenda item to the meeting minutes.

@falgunmpatel
Copy link
Contributor Author

falgunmpatel commented Mar 10, 2025

@vishalvivekm After the changes that I made to SEO.js the meta information is still preserved. I checked out the source files to confirm it.

Copy link
Member

@GARY121github GARY121github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import { navigate } from "gatsby";
import TabButton from "../../../../../reusecore/Button";

export default function SectionNav() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this function was added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already present inside the select component. Gatsby gave an error for using name exports in the Select Component, therefore I created a different component for it.

Also it is a reusable component and can be used in all other sistent components, once it is generalized.

@l5io
Copy link
Contributor

l5io commented Mar 18, 2025

🚀 Preview for commit 24389de at: https://67d91029b314b4abe6584046--layer5.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[SistentComponents] Hydration issue in the sistent component section
5 participants