-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SistentComponents] Fix Hydtration Errors #6287
base: master
Are you sure you want to change the base?
[SistentComponents] Fix Hydtration Errors #6287
Conversation
…/index.js, as they can be genralised and reused in other components as well. Signed-off-by: Falgun Patel <[email protected]>
- removed usage of defaultProps due to deprecation warnings for making it future safe. Signed-off-by: Falgun Patel <[email protected]>
🚀 Preview for commit 80a61e8 at: https://67cc2bf0f7d773407946f5db--layer5.netlify.app |
Thank you for your contribution! adding it as an agenda item to the meeting minutes. |
@vishalvivekm After the changes that I made to SEO.js the meta information is still preserved. I checked out the source files to confirm it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
import { navigate } from "gatsby"; | ||
import TabButton from "../../../../../reusecore/Button"; | ||
|
||
export default function SectionNav() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this function was added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already present inside the select component. Gatsby gave an error for using name exports in the Select Component, therefore I created a different component for it.
Also it is a reusable component and can be used in all other sistent components, once it is generalized.
🚀 Preview for commit 24389de at: https://67d91029b314b4abe6584046--layer5.netlify.app |
Description
<li>
and<a>
elements.Also removed

This PR fixes #6286
Notes for Reviewers
Signed commits