Skip to content

Desktop: fixes long lines warpped #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

amitsin6h
Copy link
Contributor

"Desktop" for the Windows/macOS/Linux app (Electron app)

@amitsin6h
Copy link
Contributor Author

@PackElend @tessus please review this updated PR

@amitsin6h amitsin6h requested a review from laurent22 February 5, 2020 18:01
@PackElend
Copy link
Contributor

I'm on mobile but I see only a single line added:question:
Moreover Travis failed, not to be resolved before PR

@amitsin6h
Copy link
Contributor Author

@PackElend adding the word-wrap: break-word; fixes the issue of long lines wrap

@PackElend
Copy link
Contributor

PackElend commented Feb 5, 2020 via email

@amitsin6h
Copy link
Contributor Author

amitsin6h commented Feb 5, 2020

@PackElend I don't why it happened, do you think is there something wrong?

@PackElend
Copy link
Contributor

PackElend commented Feb 5, 2020 via email

@tessus
Copy link
Collaborator

tessus commented Feb 5, 2020

The Travis CI error has nothing to do with your PR:

/Users/travis/build/laurent22/joplin/CliClient/tests/models_Note.js

  120:53  error  A space is required before '}'  object-curly-spacing

/Users/travis/build/laurent22/joplin/ElectronClient/app/ElectronAppWrapper.js

  127:1  error  Trailing spaces not allowed  no-trailing-spaces

@laurent22 how is this possible? shouldn't the linter only check the staged files?

@laurent22
Copy link
Owner

I don't know, but it looks good so let's merge. Thanks @amitsin6h!

@laurent22 laurent22 merged commit d24a974 into laurent22:master Feb 5, 2020
@amitsin6h
Copy link
Contributor Author

Thanks 👍

@amitsin6h
Copy link
Contributor Author

@PackElend label me, please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants