Desktop: don't count completed to-dos in note counts when they are not shown #2288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurent22
requested changes
Jan 11, 2020
|
Thanks for the pull request. Overall it looks good and other than the few comments I've left it should be good to merge. Also please install the pre commit hook as there are several linter errors. |
|
I have the pre-commit lint running but it doesn't seem to find the same errors as TravisCI and I'm not sure why. |
|
All good, thank you @lightray22! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If completed to-dos are not shown, they should not be included in the note counts. This makes to-do list functionality better as you can have the count show only the remaining to-dos.