Desktop: add Nord theme #2004
Merged
Desktop: add Nord theme #2004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code by vzsky (PR was abandoned) closes laurent22#1903
|
Sounds good to move the new theme to a separate file, but for now let's leave the other ones as they are. Perhaps we could do the refactoring in a separate pr as it would be easier to handle. |
|
Ok, makes sense, I will create a separate PR then (after this one will have been merged)... |
|
Thanks for the PR! |
scoroi
pushed a commit
to scoroi/joplin
that referenced
this pull request
Nov 10, 2019
code by vzsky (PR was abandoned) closes laurent22#1903
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code by vzsky (PR was abandoned)
closes #1903
The last OP did move the theme to its own file. I would like to do that for the other themes as well.