Desktop: Truncate update changelog when it's too long (#1222) #1967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changelong text is truncated if it's longer than 1000 characters, but avoids cutting off a partial line, unless that would lead to cutting off too much of the text. An ellipsis is added to mark the truncation. Additionally, when the changelong is truncated, it adds a "Full Release Notes" button that opens the GitHub release page in a browser window.
|
Looks good. Did you manage to test this and confirm it works? |
|
Whoops, I just saw your comment. It's already merged now anyway but yes, I tested it by forcing it to look at the version mentioned in the issue. |
scoroi
pushed a commit
to scoroi/joplin
that referenced
this pull request
Nov 10, 2019
… too long (laurent22#1967) The changelong text is truncated if it's longer than 1000 characters, but avoids cutting off a partial line, unless that would lead to cutting off too much of the text. An ellipsis is added to mark the truncation. Additionally, when the changelong is truncated, it adds a "Full Release Notes" button that opens the GitHub release page in a browser window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changelog text is truncated if it's longer than 1000 characters,
but avoids cutting off a partial line, unless that would lead to cutting
off too much of the text. An ellipsis is added to mark the truncation.
Additionally, when the changelong is truncated, it adds a "Full Release Notes"
button that opens the GitHub release page in a browser window.