Skip to content

[init] the first version of the fa.po file #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2019
Merged

[init] the first version of the fa.po file #1539

merged 2 commits into from
May 22, 2019

Conversation

mmahmoudian
Copy link
Contributor

Providing translation for Persian language

Providing translation for Persian language
@tessus tessus added the translation i18n and l10n label May 21, 2019
@tessus
Copy link
Collaborator

tessus commented May 21, 2019

@mmahmoudian thanks a lot for this.

P.S.: your info says "I don't use github much (no free private repo)" -> this is not true anymore. They have changed this a while back.

Copy link
Collaborator

@tessus tessus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file should actually be located in CliClient/locales/.

Can you please move it there?

@mmahmoudian
Copy link
Contributor Author

@tessus Thanks for checking this. Perhaps it would be nice to have this path in the README.md file under the Localisation section so prevent further confusion.

Additionally I didn't know how to calculate the completion percentage (too lazy to do it manually or write a code to do it for me), therefore I didn't add a row for Persian in the Localisation table.

P.s: Regarding my Github profile info, I had totally forgot about it and you are right, their policy have changed, but I still trying to avoid Github to be honest since I don't fully trust Microsoft products (yet, and I'll be glad to be proven wrong). Anyhow, I updated the info section :)

@laurent22
Copy link
Owner

Thanks for the translation @mmahmoudian, much appreciated!

You don't need to update the % translated because that's done automatically by the build script.

Note that I don't know much about right to left languages including Persian and Arabic, so once it's merged if you notice any mistake, feel free to let me know. It seems the UI support this outside the box but who knows.

Also I don't know if it will work with search but probably we can make it work if it doesn't.

@laurent22 laurent22 merged commit 5243ea7 into laurent22:master May 22, 2019
@tessus
Copy link
Collaborator

tessus commented May 22, 2019

@mmahmoudian

Perhaps it would be nice to have this path in the README.md file under the Localisation section so prevent further confusion

Hmm, maybe we could improve this a bit, but the second item links to a file in that directory and since all other translations are in there, I thought it should be obvious. But maybe not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation i18n and l10n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants