Skip to content

Commit 5e6ef3d

Browse files
author
manuelgitgomes
committed
#374 Bugfix to the "big red error"
1 parent c09d9e0 commit 5e6ef3d

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

atom_calibration/scripts/dataset_playback

+15-5
Original file line numberDiff line numberDiff line change
@@ -137,14 +137,17 @@ def selected_points_callback(selected_point_cloud, selection, dataset):
137137
collection_key = selection['collection_key']
138138

139139
# Extract xyz coordinates from the selected points
140-
selected_idxs = []
141140
points_selected = pc2.read_points(selected_point_cloud)
142141
gen_selected_points = list(points_selected)
143142

143+
if len(gen_selected_points) == 0: # To prevent unnecessary operations
144+
return
145+
144146
# sensor from the point cloud
145147
sensor = list(dataset['collections'][collection_key]['labels'].keys())[
146148
int(gen_selected_points[0][4])]
147149

150+
selected_idxs = []
148151
for point in gen_selected_points:
149152
selected_idxs.append(int(point[3]))
150153

@@ -163,14 +166,17 @@ def selected_points_border_callback(selected_point_cloud, selection, dataset):
163166
collection_key = selection['collection_key']
164167

165168
# Extract xyz coordinates from the selected points
166-
selected_idxs = []
167169
points_selected = pc2.read_points(selected_point_cloud)
168170
gen_selected_points = list(points_selected)
169171

172+
if len(gen_selected_points) == 0: # To prevent unnecessary operations
173+
return
174+
170175
# sensor from the point cloud
171176
sensor = list(dataset['collections'][collection_key]['labels'].keys())[
172177
int(gen_selected_points[0][4])]
173178

179+
selected_idxs = []
174180
for point in gen_selected_points:
175181
selected_idxs.append(int(point[3]))
176182

@@ -189,14 +195,17 @@ def selected_points_remove_callback(selected_point_cloud, selection, dataset):
189195
collection_key = selection['collection_key']
190196

191197
# Extract xyz coordinates from the selected points
192-
selected_idxs = []
193198
points_selected = pc2.read_points(selected_point_cloud)
194199
gen_selected_points = list(points_selected)
195200

201+
if len(gen_selected_points) == 0: # To prevent unnecessary operations
202+
return
203+
196204
# sensor from the point cloud
197205
sensor = list(dataset['collections'][collection_key]['labels'].keys())[
198206
int(gen_selected_points[0][4])]
199207

208+
selected_idxs = []
200209
for point in gen_selected_points:
201210
selected_idxs.append(int(point[3]))
202211

@@ -212,14 +221,15 @@ def selected_points_remove_callback(selected_point_cloud, selection, dataset):
212221

213222

214223
def selected_points_clear_all_callback(selected_point_cloud, selection, dataset):
215-
print('clear all')
216224

217225
collection_key = selection['collection_key']
218226
# Extract xyz coordinates from the selected points
219-
selected_idxs = []
220227
points_selected = pc2.read_points(selected_point_cloud)
221228
gen_selected_points = list(points_selected)
222229

230+
if len(gen_selected_points) == 0: # To prevent unnecessary operations
231+
return
232+
223233
# sensor from the point cloud
224234
sensor = list(dataset['collections'][collection_key]['labels'].keys())[
225235
int(gen_selected_points[0][4])]

0 commit comments

Comments
 (0)