Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route generation generates invalid typescript for routes that includes reserved javascript keywords #31

Closed
aktasumut34 opened this issue Apr 5, 2025 · 2 comments · Fixed by #32
Closed

Route generation generates invalid typescript for routes that includes reserved javascript keywords #31

aktasumut34 opened this issue Apr 5, 2025 · 2 comments · Fixed by #32

Comments

@aktasumut34
Copy link
Contributor

aktasumut34 commented Apr 5, 2025 •
edited
Loading

Wayfinder Version

0.1.3

Laravel Version

12.0

PHP Version

8.3.17

Description

At first, thank you for your efforts,

When generated route name ends with reserved javascript keywords (delete, export, import etc.), TypeScript throws ts(1389) error which is ... is not allowed as a variable declaration name..

Image

Image

Image

Steps To Reproduce

  • Fresh laravel install
  • Install wayfinder
  • Edit web.php and add a route named import and product.import

Image

  • Run wayfinder
  • See generated output
@aktasumut34 aktasumut34 mentioned this issue Apr 5, 2025
Merged
@timacdonald
Copy link
Member

timacdonald commented Apr 6, 2025 •
edited
Loading

Will close the issue and we can track #32 for the fix.

@TimKunze96 TimKunze96 mentioned this issue Apr 7, 2025
Closed
@TimKunze96
Copy link

TimKunze96 commented Apr 8, 2025 •
edited
Loading

Unfortunately this issue still exists on version v0.1.4.

import delete from './delete'
import update from './update'

const character = {
    delete, 
    update,
}

export default character

I assume this is the root cause for it:

https://github.com/laravel/wayfinder/blob/main/resources/multi-method.blade.ts?l#L10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add route prefix to reserved js keyword route names aktasumut34/wayfinder
3 participants
@timacdonald @TimKunze96 @aktasumut34