Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support select-type variables in Metadata Filtering (#17440 #17445

Conversation

marcelodiaz558
Copy link
Contributor

Summary

Description

This PR adds support for select-type variables in the Metadata Filtering feature for knowledge retrieval.
Previously, only string and number variables were supported, but select variables (dropdown options)
were being filtered out despite being functionally equivalent to strings at runtime.

Changes Made

  • Added 'select' to MetadataFilteringVariableType enum
  • Updated dataset-config component to include select variables in the string variable filter
  • Modified utils.ts to apply string-type operators to select variables
  • Updated condition-item.tsx to handle and render select variables as strings
  • Added select variable support to the metadata icon component

Testing Done

Tested the changes by:

  • Creating an app with select-type variables
  • Confirming select variables now appear in the metadata filtering dropdown
  • Verifying that filtering with select variables works as expected in knowledge retrieval

fixes #17440

Screenshots

Before:

430183974-216afe0f-c5fa-4608-870d-1add2184eaa1

After:

image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 💪 enhancement New feature or request labels Apr 4, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 8, 2025
@crazywoola crazywoola merged commit d796fcc into langgenius:main Apr 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select variables not appearing in Metadata Filtering dropdown
2 participants