Skip to content

Contaminated db commit message #14786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 5 tasks
bowenliang123 opened this issue Mar 3, 2025 · 1 comment · Fixed by #14787
Closed
4 of 5 tasks

Contaminated db commit message #14786

bowenliang123 opened this issue Mar 3, 2025 · 1 comment · Fixed by #14787
Labels
🐞 bug Something isn't working

Comments

@bowenliang123
Copy link
Contributor

Self Checks

  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue,否则会被关闭。谢谢!:)
  • Please do not modify this template :) and fill in all the required fields.

1. Is this request related to a challenge you're experiencing? Tell me about your story.

  • contaminated db migration commit message in e1944c35e15e , when running flask db upgrade
INFO  [alembic.runtime.migration] Running upgrade cf8f4fc45278 -> 11b07f66c737, remove unused tool_providers
INFO  [alembic.runtime.migration] Running upgrade 11b07f66c737 -> e1944c35e15e, add retry_index field to node-execution model
Revision ID: e1944c35e15e
Revises: 11b07f66c737
Create Date: 2024-12-20 06:28:30.287197
INFO  [alembic.runtime.migration] Running upgrade e1944c35e15e -> d7999dfa4aae, remove workflow_node_executions.retry_index if exists
INFO  [alembic.runtime.migration] Running upgrade d7999dfa4aae -> e19037032219, parent-child-index

2. Additional context or comments

  • it should be fixed from
INFO  [alembic.runtime.migration] Running upgrade 11b07f66c737 -> e1944c35e15e, add retry_index field to node-execution model
Revision ID: e1944c35e15e
Revises: 11b07f66c737
Create Date: 2024-12-20 06:28:30.287197

into

INFO  [alembic.runtime.migration] Running upgrade 11b07f66c737 -> e1944c35e15e, add retry_index field to node-execution model

3. Can you help us with this feature?

  • I am interested in contributing to this feature.
Copy link

dosubot bot commented Mar 3, 2025

The migration with revision ID e1944c35e15e was intended to add a retry_index field to the workflow_node_executions model, but the actual changes were not implemented in the upgrade and downgrade functions. This is indicated by the commented-out code and the note that the change will be reverted in the next migration. The subsequent migration with revision ID d7999dfa4aae explicitly checks for the existence of the retry_index column and removes it if it exists, confirming that the changes associated with e1944c35e15e were not meant to be permanent [1][2].

If you want to address the issue with the commit message, you might consider updating the migration script to reflect the actual changes made, or lack thereof, in the upgrade and downgrade functions. This would ensure that the commit message accurately represents the migration's purpose and actions.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
1 participant