-
Notifications
You must be signed in to change notification settings - Fork 14k
The Rerank model in RAG needs to support independent score_threshold and top_k #11068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
A lot of people have been giving feedback for a long time, like: #7187, and the officials are aware of it, but are slow to change it. |
I’ll ping our team about this feature request. |
Hi! The |
I reviewed the process again, and there are two settings here:
Suppose I have
I don't know if what I wrote above is accurate. |
You are correct, but this would result in a knowledge base filled with too many configurations. So, we don't have any plans to change it right now. |
@laipz8200 |
We won't merge it because its design is not as we expect, but you can still keep it in your version if you want. |
I also consider what you mentioned. In the current ChatFlow process, we need to rerank twice: first in the knowledge base and then in the aggregated chunks from multiple datasets. The first rerank is not necessary. |
@hustyichi Thank you for your response. We understand the issue but believe this approach helps prevent adding too many settings to the knowledge base feature, making it easier for users to use. I have forwarded this issue to our product team, and it may change in the future. |
Self Checks
1. Is this request related to a challenge you're experiencing? Tell me about your story.
Currently, the retrieval model and the re-ranking stage share the score_threshold and top_k parameters, which currently have the following problems:
2. Additional context or comments
No response
3. Can you help us with this feature?
The text was updated successfully, but these errors were encountered: