Skip to content

Commit e565ecd

Browse files
authored
fix: change workflow trace id (#11585)
1 parent f96fdc2 commit e565ecd

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

api/core/ops/langfuse_trace/langfuse_trace.py

+9-6
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,11 @@ def trace(self, trace_info: BaseTraceInfo):
6565
self.generate_name_trace(trace_info)
6666

6767
def workflow_trace(self, trace_info: WorkflowTraceInfo):
68-
trace_id = trace_info.workflow_app_log_id or trace_info.workflow_run_id
68+
trace_id = trace_info.workflow_run_id
6969
user_id = trace_info.metadata.get("user_id")
70+
metadata = trace_info.metadata
71+
metadata["workflow_app_log_id"] = trace_info.workflow_app_log_id
72+
7073
if trace_info.message_id:
7174
trace_id = trace_info.message_id
7275
name = TraceTaskName.MESSAGE_TRACE.value
@@ -76,22 +79,22 @@ def workflow_trace(self, trace_info: WorkflowTraceInfo):
7679
name=name,
7780
input=trace_info.workflow_run_inputs,
7881
output=trace_info.workflow_run_outputs,
79-
metadata=trace_info.metadata,
82+
metadata=metadata,
8083
session_id=trace_info.conversation_id,
8184
tags=["message", "workflow"],
8285
created_at=trace_info.start_time,
8386
updated_at=trace_info.end_time,
8487
)
8588
self.add_trace(langfuse_trace_data=trace_data)
8689
workflow_span_data = LangfuseSpan(
87-
id=(trace_info.workflow_app_log_id or trace_info.workflow_run_id),
90+
id=trace_info.workflow_run_id,
8891
name=TraceTaskName.WORKFLOW_TRACE.value,
8992
input=trace_info.workflow_run_inputs,
9093
output=trace_info.workflow_run_outputs,
9194
trace_id=trace_id,
9295
start_time=trace_info.start_time,
9396
end_time=trace_info.end_time,
94-
metadata=trace_info.metadata,
97+
metadata=metadata,
9598
level=LevelEnum.DEFAULT if trace_info.error == "" else LevelEnum.ERROR,
9699
status_message=trace_info.error or "",
97100
)
@@ -103,7 +106,7 @@ def workflow_trace(self, trace_info: WorkflowTraceInfo):
103106
name=TraceTaskName.WORKFLOW_TRACE.value,
104107
input=trace_info.workflow_run_inputs,
105108
output=trace_info.workflow_run_outputs,
106-
metadata=trace_info.metadata,
109+
metadata=metadata,
107110
session_id=trace_info.conversation_id,
108111
tags=["workflow"],
109112
)
@@ -192,7 +195,7 @@ def workflow_trace(self, trace_info: WorkflowTraceInfo):
192195
metadata=metadata,
193196
level=(LevelEnum.DEFAULT if status == "succeeded" else LevelEnum.ERROR),
194197
status_message=trace_info.error or "",
195-
parent_observation_id=(trace_info.workflow_app_log_id or trace_info.workflow_run_id),
198+
parent_observation_id=trace_info.workflow_run_id,
196199
)
197200
else:
198201
span_data = LangfuseSpan(

api/core/ops/langsmith_trace/langsmith_trace.py

+8-6
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,17 @@ def trace(self, trace_info: BaseTraceInfo):
6262
self.generate_name_trace(trace_info)
6363

6464
def workflow_trace(self, trace_info: WorkflowTraceInfo):
65-
trace_id = trace_info.message_id or trace_info.workflow_app_log_id or trace_info.workflow_run_id
65+
trace_id = trace_info.message_id or trace_info.workflow_run_id
6666
message_dotted_order = (
6767
generate_dotted_order(trace_info.message_id, trace_info.start_time) if trace_info.message_id else None
6868
)
6969
workflow_dotted_order = generate_dotted_order(
70-
trace_info.workflow_app_log_id or trace_info.workflow_run_id,
70+
trace_info.workflow_run_id,
7171
trace_info.workflow_data.created_at,
7272
message_dotted_order,
7373
)
74+
metadata = trace_info.metadata
75+
metadata["workflow_app_log_id"] = trace_info.workflow_app_log_id
7476

7577
if trace_info.message_id:
7678
message_run = LangSmithRunModel(
@@ -82,7 +84,7 @@ def workflow_trace(self, trace_info: WorkflowTraceInfo):
8284
start_time=trace_info.start_time,
8385
end_time=trace_info.end_time,
8486
extra={
85-
"metadata": trace_info.metadata,
87+
"metadata": metadata,
8688
},
8789
tags=["message", "workflow"],
8890
error=trace_info.error,
@@ -94,15 +96,15 @@ def workflow_trace(self, trace_info: WorkflowTraceInfo):
9496
langsmith_run = LangSmithRunModel(
9597
file_list=trace_info.file_list,
9698
total_tokens=trace_info.total_tokens,
97-
id=trace_info.workflow_app_log_id or trace_info.workflow_run_id,
99+
id=trace_info.workflow_run_id,
98100
name=TraceTaskName.WORKFLOW_TRACE.value,
99101
inputs=trace_info.workflow_run_inputs,
100102
run_type=LangSmithRunType.tool,
101103
start_time=trace_info.workflow_data.created_at,
102104
end_time=trace_info.workflow_data.finished_at,
103105
outputs=trace_info.workflow_run_outputs,
104106
extra={
105-
"metadata": trace_info.metadata,
107+
"metadata": metadata,
106108
},
107109
error=trace_info.error,
108110
tags=["workflow"],
@@ -204,7 +206,7 @@ def workflow_trace(self, trace_info: WorkflowTraceInfo):
204206
extra={
205207
"metadata": metadata,
206208
},
207-
parent_run_id=trace_info.workflow_app_log_id or trace_info.workflow_run_id,
209+
parent_run_id=trace_info.workflow_run_id,
208210
tags=["node_execution"],
209211
id=node_execution_id,
210212
trace_id=trace_id,

0 commit comments

Comments
 (0)