Skip to content

Commit d140920

Browse files
committed
Ensure deletion queries
1 parent f055884 commit d140920

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

api/core/rag/datasource/vdb/couchbase/couchbase_vector.py

+11-5
Original file line numberDiff line numberDiff line change
@@ -240,16 +240,20 @@ def delete_by_ids(self, ids: list[str]) -> None:
240240
WHERE META().id IN $doc_ids;
241241
"""
242242
try:
243-
self._cluster.query(query, named_parameters={'doc_ids': ids})
243+
result = self._cluster.query(query, named_parameters={'doc_ids': ids})
244+
# force evaluation of the query to ensure deletion occurs
245+
list(result)
244246
except Exception as e:
245-
print(e)
247+
logger.error(e)
246248

247249
def delete_by_document_id(self, document_id: str):
248250
query = f"""
249251
DELETE FROM `{self._client_config.bucket_name}`.{self._client_config.scope_name}.{self._collection_name}
250252
WHERE META().id = $doc_id;
251253
"""
252-
self._cluster.query(query,named_parameters={'doc_id':document_id})
254+
result = self._cluster.query(query,named_parameters={'doc_id':document_id})
255+
# force evaluation of the query to ensure deletion occurs
256+
list(result)
253257

254258
# def get_ids_by_metadata_field(self, key: str, value: str):
255259
# query = f"""
@@ -265,7 +269,9 @@ def delete_by_metadata_field(self, key: str, value: str) -> None:
265269
DELETE FROM `{self._client_config.bucket_name}`.{self._client_config.scope_name}.{self._collection_name}
266270
WHERE metadata.{key} = $value;
267271
"""
268-
self._cluster.query(query, named_parameters={'value':value})
272+
result = self._cluster.query(query, named_parameters={'value':value})
273+
# force evaluation of the query to ensure deletion occurs
274+
list(result)
269275

270276
def search_by_vector(
271277
self,
@@ -387,4 +393,4 @@ def init_vector(self, dataset: Dataset, attributes: list, embeddings: Embeddings
387393
bucket_name=config.get('COUCHBASE_BUCKET_NAME'),
388394
scope_name=config.get('COUCHBASE_SCOPE_NAME'),
389395
)
390-
)
396+
)

0 commit comments

Comments
 (0)